Jira (PUP-3042) If a catalog has a dependency cycle, it does not count as failed

Title: Message Title

Josh Cooper commented on

PUP-3042

Verified using:

$ cat cycle.rb

notify { foo: require => Notify[bar] }

notify { bar: require => Notify[foo] }

$ bx puppet apply cycle.rb

Notice: Compiled catalog for XXX in environment production in 0.05 seconds

Error: Found 1 dependency cycle:

(Notify[bar] => Notify[foo] => Notify[bar])

Try the '--graph' option and opening the resulting '.dot' file in OmniGraffle or GraphViz

Error: Failed to apply catalog: One or more resource dependency cycles detected in graph

The overall report status is failed:

cat ~/.puppetlabs/opt/puppet/cache/state/last_run_report.yaml

--- !ruby/object:Puppet::Transaction::Report

host: XXX

time: '2017-06-08T16:00:07.363456000-07:00'

configuration_version: 1496962807

transaction_uuid: d39cd850-0b0e-4358-a145-1b88c70d0f17

report_format: 7

puppet_version: 5.0.0

status: failed

noop: false

noop_pending: false

environment: production

And the status for each resource is failed

resource_statuses:

  Notify[bar]:

    title: bar

    file: "/Users/josh/work/puppet/cycle.rb"

    line: 2

    resource: Notify[bar]

    resource_type: Notify

    containment_path:

    - Stage[main]

    - Main

    - Notify[bar]

    evaluation_time:

    tags:

    - notify

    - bar

    - class

    time: '2017-06-08T16:00:07.368565000-07:00'

    failed: true

    changed: false

    out_of_sync: true

    skipped: false

    change_count: 0

    out_of_sync_count: 1

    corrective_change: false

And the status has an event with status failure:

    events:

    - property:

      previous_value:

      desired_value:

      message: resource is part of a dependency cycle

      name: resource_error

      status: failure

      time: '2017-06-08T16:00:07.368789000-07:00'

      redacted: false

      corrective_change: false

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Reply via email to