Jira (PUP-3551) Sanitize non-UTF-8 data in run reports

[Moses Mendoza (JIRA)]

Title: Message Title

Moses Mendoza commented on PUP-3551   Re: Sanitize non-UTF-8 data in run reports I believe this maybe has been resolved as part of work done on PUP-5756 / PUP-7498 . In https://github.com/puppetlabs/puppet/pull/5772/commits/c47be2d3b3d002f02cbed6edee8dfee119152b46, we modified logging to convert data to UTF-8, and for invalid UTF-8 we emit a warning and escaped sequences (valid UTF-8). Because the transaction is evaluated with the report as a log destination, I believe data generated by resource evaluation will be logged through this framework, resulting in a report that has only valid UTF-8 in it. For example, for a file resource containing invalid UTF-8 that was changed, the diff message now contains: Received a log message with invalid encoding:"\n--- /tmp/utf8.txt\t2017-06-13 14:45:27.490300115 -0700\n+++ /tmp/puppet-file20170613-3160-1gr3fg7\t2017-06-13 14:45:37.977434824 -0700\n@@ -1,300 +1 @@... which is what is stored in the report and sent (successfully) to the server. I'm not sure if there's another way for invalid UTF-8 to make its way into the report outside of resource evaluation, but it seems unlikely? Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.