Jira (PUP-7789) Manifest ordering not respected if resources are nested in defined types

[Alex Harvey (JIRA)]

Title: Message Title

Alex Harvey updated an issue   Puppet / PUP-7789 Manifest ordering not respected if resources are nested in defined types Change By: Alex Harvey h3. Manifest ordering not always respected When relying on manifest ordering to order things as they appear in the manifest, resources sometimes will not in fact be manifest-ordered if some of the resources are defined types. h3. To reproduce {code :puppet } class foo () {   foo::bar { 'bar': } } define foo::bar {   foo::baz { 'a': }   foo::baz { 'b': }   foo::baz { 'c': }   File {     ensure => file,   }   file { '/d': }   file { '/e': }   file { '/f': } } define foo::baz {   file { "/$name": ensure => file } } include foo {code} Then: {code} $ puppet apply foo.pp --ordering=manifest --noop {code} h3. Expected result I expect to see resources ordered as they appear in the manifest, namely: * Foo::Baz[a] * Foo::Baz[b] * Foo::Baz[c] * File[/d] * File[/e] * File[/f] h3. Actual result * File[/d] * File[/e] * File[/f] * Foo::Baz[a] * Foo::Baz[b] * Foo::Baz[c] {code} Notice: Compiled catalog for alexs-macbook-pro-2.local in environment production in 0.02 seconds Notice: /Stage[main]/Foo/Foo::Bar[bar]/File[/d]/ensure: current_value 'absent', should be 'file' (noop) Notice: /Stage[main]/Foo/Foo::Bar[bar]/File[/e]/ensure: current_value 'absent', should be 'file' (noop) Notice: /Stage[main]/Foo/Foo::Bar[bar]/File[/f]/ensure: current_value 'absent', should be 'file' (noop) Notice: /Stage[main]/Foo/Foo::Bar[bar]/Foo::Baz[a]/File[/a]/ensure: current_value 'absent', should be 'file' (noop) Notice: Foo::Baz[a]: Would have triggered 'refresh' from 1 event Notice: /Stage[main]/Foo/Foo::Bar[bar]/Foo::Baz[b]/File[/b]/ensure: current_value 'absent', should be 'file' (noop) Notice: Foo::Baz[b]: Would have triggered 'refresh' from 1 event Notice: /Stage[main]/Foo/Foo::Bar[bar]/Foo::Baz[c]/File[/c]/ensure: current_value 'absent', should be 'file' (noop) Notice: Foo::Baz[c]: Would have triggered 'refresh' from 1 event Notice: Foo::Bar[bar]: Would have triggered 'refresh' from 6 events Notice: Class[Foo]: Would have triggered 'refresh' from 1 event Notice: Stage[main]: Would have triggered 'refresh' from 1 event Notice: Applied catalog in 0.07 seconds {code} Affects all versions of Puppet, including 3.8.7. Presumably it has always been like this. However, this is a very confusing ordering that seems to defeat the purpose of having manifest ordering at all. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.