Issue #4783 has been updated by Matt Robinson. Status changed from Code Insufficient to Ready for Checkin
Of course, the problem was that there are errors when you test on systems that don't have RRDtool installed. Simply stubbing out the method call that makes the RRDtool graph call fixes this. I tried writing a better test that more fully exercises the code that I'm stubbing out, but it required refactoring the way we called RRDtool and conflicted with Jesse's patch for #4726. Really we should have wrapped RRDtool and the newer librrd4 in a class so that we could stub that wrapper class for testing. Unfortunately, that's not how #4726 was done, it's already in, and it's probably not worth spending a ton of time refactoring this right now. So, I've updated my branch so that the spec tests will pass on machines without RRDtool installed. ---------------------------------------- Bug #4783: rrd reporting not generating rrd files http://projects.puppetlabs.com/issues/4783 Author: Frank Louwers Status: Ready for Checkin Priority: High Assignee: Matt Robinson Category: reports Target version: 2.6.2 Affected version: 2.6.0 Keywords: rrd rrdtool graph Branch: http://github.com/mmrobins/puppet/tree/ticket/2.6.x/4783 I've setup rrdreporting, but the rrd files aren't being generated. This is the stacktrace: <pre> /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/util/metric.rb:47:in `create' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/util/metric.rb:121:in `store' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/reports/rrdgraph.rb:113:in `process' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/reports/rrdgraph.rb:106:in `each' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/reports/rrdgraph.rb:106:in `process' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/indirector/report/processor.rb:32:in `process' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/indirector/report/processor.rb:25:in `each' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/indirector/report/processor.rb:25:in `process' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/indirector/report/processor.rb:14:in `save' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/indirector/indirection.rb:253:in `save' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/indirector.rb:64:in `save' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/handler.rb:168:in `save_object' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/handler.rb:143:in `do_save' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/handler.rb:68:in `send' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/handler.rb:68:in `process' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/webrick/rest.rb:23:in `service' /opt/lib/ruby/1.8/webrick/httpserver.rb:104:in `service' /opt/lib/ruby/1.8/webrick/httpserver.rb:65:in `run' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/webrick.rb:45:in `listen' /opt/lib/ruby/1.8/webrick/server.rb:173:in `call' /opt/lib/ruby/1.8/webrick/server.rb:173:in `start_thread' /opt/lib/ruby/1.8/webrick/server.rb:162:in `start' /opt/lib/ruby/1.8/webrick/server.rb:162:in `start_thread' /opt/lib/ruby/1.8/webrick/server.rb:95:in `start' /opt/lib/ruby/1.8/webrick/server.rb:92:in `each' /opt/lib/ruby/1.8/webrick/server.rb:92:in `start' /opt/lib/ruby/1.8/webrick/server.rb:23:in `start' /opt/lib/ruby/1.8/webrick/server.rb:82:in `start' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/webrick.rb:42:in `listen' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/webrick.rb:41:in `initialize' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/webrick.rb:41:in `new' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/webrick.rb:41:in `listen' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/webrick.rb:38:in `synchronize' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/http/webrick.rb:38:in `listen' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/server.rb:127:in `listen' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/network/server.rb:142:in `start' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/daemon.rb:125:in `start' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/application/master.rb:114:in `main' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/application/master.rb:46:in `run_command' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/application.rb:301:in `run' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/application.rb:398:in `exit_on_fail' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/lib/puppet/application.rb:301:in `run' /opt/lib/ruby/gems/1.8/gems/puppet-2.6.0/bin/puppetmasterd:4 /opt/bin/puppetmasterd:19:in `load' /opt/bin/puppetmasterd:19 err: Report rrdgraph failed: Could not create RRD file /var/lib/puppet/rrd/frankfest.openminds.be/time.rrd: you must define at least one Data Source </pre> -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
