Jira (PUP-7802) Disabling automatic class parameter lookup in Hiera 5 also disables the global hierarchy layer

[Charlie Sharpsteen (JIRA)]

Title: Message Title

Charlie Sharpsteen created an issue   Puppet / PUP-7802 Disabling automatic class parameter lookup in Hiera 5 also disables the global hierarchy layer Issue Type: Bug Affects Versions: PUP 4.10.4, PUP 4.9.0 Assignee: Thomas Hallgren Components: Hiera & Lookup Created: 2017/07/24 4:28 PM Priority: Normal Reporter: Charlie Sharpsteen Disabling automatic class parameter lookup in Hiera 5 also disables the global hierarchy layer Prior to Puppet 4.9.0 and the integration of Hiera 5, setting the data_binding_terminus to none would disable automatic lookup of class parameters while keeping explicit lookups via the hiera() functions enabled. Starting with Puppet 4.9.0, setting data_binding_terminus to none disables hiera() entirely. Reproduction Case Install PE 2016.4.6. Replace ` /etc/puppetlabs/code/environments/production/manifests/site.pp` with the following content: class testclass ( $param1 = 'default', $param2 = 'default', ) {   notify {"param1: ${param1}": } notify {"param2: ${param2}": }   }   node default { class {'testclass': param1 => hiera('param1'), } } Add the following data to /etc/puppetlabs/code/environments/production/hieradata/common.yaml: param1: hiera_override testclass::param2: hiera_override Disable the data_binding_terminus: puppet config set section master data_binding_terminus none Re-start pe-puppetserver Run puppet agent -t Outcome The puppet run fails with a lookup() error: [root@pe-201646-master production]# puppet agent -t Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Error: Could not retrieve catalog from remote server: Error 500 on SERVER: Server Error: Function lookup() did not find a value for the name 'param1' on node pe-201646-master.puppetdebug.vlan Warning: Not using cache on failed catalog Error: Could not retrieve catalog; skipping run Expected Outcome The run succeeds, and only param1 of testclass is overridden via Hiera data: [root@pe-201643-master manifests]# puppet agent -t Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for pe-201643-master.puppetdebug.vlan Info: Applying configuration version '1500938483' Notice: param1: hiera_override Notice: /Stage[main]/Testclass/Notify[param1: hiera_override]/message: defined 'message' as 'param1: hiera_override' Notice: param2: default Notice: /Stage[main]/Testclass/Notify[param2: default]/message: defined 'message' as 'param2: default' Notice: Applied catalog in 11.76 seconds This was the behavior prior to Puppet 4.9. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.