readme seem to be wrong

Geoff Williams (JIRA) Tue, 22 Aug 2017 22:27:14 -0700

Title: Message Title

Geoff Williams created an issue

PUP-7861

Issue Type:	Bug
Assignee:	Eric Sorenson
Components:	Test Infrastructure
Created:	2017/08/22 10:25 PM
Priority:	Normal
Reporter:	Geoff Williams

Instructions for running beaker locally in the file acceptance/README.md seem to be broken in master.

I've been running using:

CONFIG=config/nodes/centos6-local.yaml SHA=#{test-commit-sha} GIT_SERVER='192.168.80.1' FORK='puppet' bundle exec rake --trace ci:test:git

As suggested by the instructions, I encountered 2x failures:

Errored build: Unable to yum install rubygem-json
Fix was to use a centos7 vagrant box which already has "Development Tools" metapackage installed

Errored build: Unable to checkout puppet from git

...SNIP

    Don't run Bundler as root. Bundler can ask for sudo if it is needed, and

    installing your bundle as root will break this application for all non-root

    users on this machine.

    Fetching https://github.com/puppet/puppet.git

    fatal: Needed a single revision

    Revision 15ffe6b31 does not exist in the repository

    https://github.com/puppet/puppet.git. Maybe you misspelled it?

  all-in-one executed in 226.35 seconds

  Exited: 11

  Beaker::Host::CommandFailure: Host 'all-in-one' exited with 11 running:

...SNIP

This turns out to be the build system not using the GIT_SERVER environment variable. I had a quick scan through the code and couldn't see it being used anywhere. I came up with a hacky workaround by editing acceptance/setup/git/pre-suite/010_TestSetup.rb around line 35 to just hardcode to the git server I setup (git daemon, as per instructions):

        gemfile_contents = <<END

source '#{ENV["GEM_SOURCE"] || "https://rubygems.org"}'

gem '#{repository[:name]}', :git => 'git://192.168.0.1/puppetlabs-puppet.git', :ref => '#{ENV['SHA']}'

# gem '#{repository[:name]}', :git => '#{repository[:path]}', :ref => '#{ENV['SHA']}'

END

After making these two changes, it looks like the beaker tests are mostly working, but it would be great to get the instructions updated/helpers fixed to make life easier for those contributing patches

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-7861) beaker instructions at ./acceptance/readme seem to be wrong

Reply via email to