Issue #4020 has been updated by Gabriel Filion.
Matt Robinson wrote: > Gabriel, did you get a chance to incorporate that feedback, or did you decide > it wasn't necessary to make the changes suggested? Actually, I can't really help a lot with writing and testing code since I would have to learn ruby first :P however: > Looks like this patch has been forgotten about to some degree. I didn't > realize we had a naginator project, but I can't update ticket statuses. It > looks to me like the last patch that Brian attached to this ticket was > submitted to the dev list and Luke had some comments that I don't see > reflected in the patch. right. I saw you e-mail on the puppet-dev list and here are my thoughts about James' comments: * yes it is true, order of the group names should not make (a,b) and (b,a) differ * nagios group names are always strings so James' modifications would seem ok and simple to integrate into the patch. ---------------------------------------- Feature #4020: metaparameter "hostgroups" in nagios_host type should accept arrays http://projects.puppetlabs.com/issues/4020 Author: Gabriel Filion Status: Ready for Checkin Priority: Normal Assignee: Markus Roberts Category: Target version: queued Keywords: Branch: When supplying an array of strings to the hostgroups value of nagios_host resources, the strings should be joined by commas. currently, doing so: nagios_host{ "foo.bar": address => "foo.bar", hostgroups => ["hello", "world"], } results in something like the following: define host { address foo.bar host_name foo.bar hostgroups hello } It should instead read: define host { address foo.bar host_name foo.bar hostgroups hello,world } -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
