Jira (HI-581) If invoked from rspec test for Windows, hiera() attempts `require win32`, fails

[Reid Vandewiele (JIRA)]

Title: Message Title

Reid Vandewiele updated an issue   Hiera / HI-581 If invoked from rspec test for Windows, hiera() attempts `require win32`, fails Change By: Reid Vandewiele On Friday, Sep. 8th Reid Vandewiele and Bryan Jen did some live debugging of rspec tests with a customer. The customer has modules that do direct hiera lookups in manifests. When doing rspec tests of these modules, tests fail `it should compile` on their windows test contexts because hiera tries to load win32 libraries on their OS X workstations. This is exactly what DavidS was able to find when doing a recreate. The solution provided by DavidS was also successful in getting their tests to pass. Customer mentioned that these tests were working with Hiera gem version 3.1 and 3.2, stopped working when upgraded to 3.4. Bryan Jen identified this PR as the source of the change in behavior:  https://github.com/puppetlabs/hiera/pull/393 While better rspec practices would help customers avoid this problem, we should still fix the behavior regression in Hiera. h3. Reproduction {code:title=test/manifests/init.pp} class test (   $param = hiera('test', 'default'), ) {   # empty body } {code} {code:title=test/spec/classes/test_spec.rb} require 'spec_helper' describe 'test' do   context 'windows' do     let(:facts) {{ 'operatingsystem' => 'windows' }}     it { is_expected.to compile }   end end {code} {code:title=`bundle exec rake spec`} test   windows     should compile into a catalogue without dependency cycles (FAILED - 1) Failures:   1) test windows should compile into a catalogue without dependency cycles      Failure/Error: it { is_expected.to compile }        error during compilation: Evaluation Error: Error while evaluating a Function Call, can't load shell32 at /Users/reidmv/src/puppet-test/spec/fixtures/modules/test/manifests/init.pp:2:12 on node .delivery.puppetlabs.net      # ./spec/classes/test_spec.rb:6:in `block (3 levels) in <top (required)>' Finished in 0.12493 seconds (files took 0.98195 seconds to load) 1 example, 1 failure Failed examples: rspec ./spec/classes/test_spec.rb:6 # test windows should compile into a catalogue without dependency cycles {code} Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.