Jira (PUP-7935) Prefetching custom types not possible if namevar is not "name"

Reinhard Vicinus (JIRA) Mon, 11 Sep 2017 13:22:28 -0700

Title: Message Title

Reinhard Vicinus created an issue

PUP-7935

Issue Type:	Bug
Affects Versions:	PUP 4.10.7
Assignee:	Unassigned
Created:	2017/09/11 1:21 PM
Priority:	Minor
Reporter:	Reinhard Vicinus

Is it a bug or a feature that it is not possible to prefetch custom types if the namevar parameter is not named "name", because in puppet/provider.rb: @property_hash[:name] is hardcoded.

Here an simple example for clarification of the issue:

test/lib/puppet/type/touchfile.rb
Puppet::Type.newtype(:touchfile) do

ensurable

newparam(:filename) do
isnamevar
end
end

test/lib/puppet/provider/touchfile/default.rb
Puppet::Type.type(:touchfile).provide(:default) do

commands :touch => 'touch', :rm => 'rm'

def self.instances
Dir["/tmp/*.txt"].collect do \|filename\|
new(
:filename => filename,
)
end
end

def self.prefetch(resources)
instances.each do \|prov\|
if tf = resources[prov.name]
tf.provider = prov
end
end
end

def create
touch(["/tmp/#{@resource[:filename]}.txt"])
end

def destroy
rm(["/tmp/#{@resource[:filename]}.txt"])
end

def exists?
File.exist?("/tmp/#{@resource[:filename]}.txt")
end
end

The above creates the following error if a txt file is inside of /tmp/:

puppet apply --modulepath=/data/modules -e 'touchfile { "dummy": }' --trace

Notice: Compiled catalog for test.example.com in environment production in 0.13 seconds

Error: Failed to apply catalog: No resource and no name in property hash in default instance

/opt/puppetlabs/puppet/lib/ruby/vendor_ruby/puppet/provider.rb:531:in `name'

[...]

If the namevar parameter is renamed from "filename" to "name" it works without problems.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-7935) Prefetching custom types not possible if namevar is not "name"

Reply via email to