Jira (PUP-7948) selmodversion_loaded lines variable broken

[Eric Delaney (JIRA)]

Title: Message Title

Eric Delaney created an issue   Puppet / PUP-7948 selmodversion_loaded lines variable broken Issue Type: Bug Affects Versions: PUP 5.3.0 Assignee: Unassigned Created: 2017/09/13 2:31 PM Priority: Normal Reporter: Eric Delaney I was playing with rubocop when it complained about: == lib/puppet/provider/selmodule/semodule.rb == W:121: 13: Lint/EmptyExpression: Avoid empty expressions. Looking at the code its complaining about the "lines = ()" assignment: def selmodversion_loaded lines = () begin execpipe("# {command(:semodule)} --list") do |output| output.each_line do |line| line.chomp! bits = line.split if bits[0] == @resource[:name] self.debug "load version # {bits[1]} " return bits[1] end end end rescue Puppet::ExecutionFailure raise Puppet::ExecutionFailure, "Could not list policy modules: # {lines.join(' ').chomp!} ", $!.backtrace end nil end {code] Looking at the code, lines will be assigned "nil" which doesn't have a .join method. So the exception will fail. We also fail to do anything with the lines variable in the method so if it was intended to be an array, it never gets changed from an empty array which is kind of pointless. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.