Jira (FACT-1754) fact "java_version" fails when JAVA_TOOL_OPTIONS is used

[Sebastian Huebner (JIRA)]

Title: Message Title

Sebastian Huebner created an issue   Facter / FACT-1754 fact "java_version" fails when JAVA_TOOL_OPTIONS is used Issue Type: Bug Affects Versions: FACT 3.9.0 Assignee: Unassigned Created: 2017/09/18 5:13 AM Environment: Tested on Debian 8.9, but is most probably independent of OS Priority: Normal Reporter: Sebastian Huebner Synopsis: When JAVA_TOOL_OPTIONS is used, for example with JAVA_TOOL_OPTIONS=-Djava.net.preferIPv4Stack=true, facter is not able to correctly read the version number. Facter expects the version number to be in the first line: # java -version java version "1.8.0_77" Java(TM) SE Runtime Environment (build 1.8.0_77-b03) Java HotSpot(TM) 64-Bit Server VM (build 25.77-b03, mixed mode) But when JAVA_TOOL_OPTIONS is used, java inserts a new first line: # JAVA_TOOL_OPTIONS=-Djava.net.preferIPv4Stack=true java -version Picked up JAVA_TOOL_OPTIONS: -Djava.net.preferIPv4Stack=true java version "1.8.0_77" Java(TM) SE Runtime Environment (build 1.8.0_77-b03) Java HotSpot(TM) 64-Bit Server VM (build 25.77-b03, mixed mode) Consequently, facters test fails when JAVA_TOOL_OPTIONS contains no quote sign: Facter::Util::Resolution.exec('java -Xmx12m -version 2>&1').lines.first.split(/"/)[1].strip In case JAVA_TOOL_OPTIONS should contain a quote sign, the result is plain wrong and will lead to subsequents faults, e.g., in java_major_version. Verified on Debian 8.9, should also fail on Windows. The same test is used for OpenBSD and Darwin (lines 38 and 49), and should also fail. Note: the new first line as well as the version number is under Linux written to stderr. It is therefore not possible to just redirect the additional output to circumvent the problem. The code needs to search for the "^java version" line. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.