Jira (FACT-1759) facter should compute the correct logical and physical cpu count on Power for the processors.count and processors.physicalcount facts

[Enis Inan (JIRA)]

Title: Message Title

Enis Inan created an issue   Facter / FACT-1759 facter should compute the correct logical and physical cpu count on Power for the processors.count and processors.physicalcount facts Issue Type: Bug Assignee: Unassigned Created: 2017/09/21 2:07 PM Priority: Normal Reporter: Enis Inan On Power for RedHat and Ubuntu, the number of physical (and logical) CPUs reported by Facter do not match up to what is listed in /proc/cpuinfo. For example, on an Ubuntu machine, here is the relevant output for the "processors" fact after running facter: processors => { count => 160, isa => "ppc64le", physicalcount => 160 } while the corresponding /proc/cpuinfo file is: processor : 0 cpu : POWER8 (raw), altivec supported clock : 2926.000000MHz revision : 2.0 (pvr 004d 0200)   processor : 1 cpu : POWER8 (raw), altivec supported clock : 2926.000000MHz revision : 2.0 (pvr 004d 0200)   processor : 2 cpu : POWER8 (raw), altivec supported clock : 2926.000000MHz revision : 2.0 (pvr 004d 0200)   processor : 3 cpu : POWER8 (raw), altivec supported clock : 2926.000000MHz revision : 2.0 (pvr 004d 0200)   timebase : 512000000 platform : pSeries model : IBM pSeries (emulated by qemu) machine : CHRP IBM pSeries (emulated by qemu) indicating 4 vs. 160. This is two orders of magnitude lower than what facter reports. On non-power machines, this discrepancy does not occur – /proc/cpuinfo and "processors" are in sync. My guess is that /proc/cpuinfo reports the physical CPUs here, because this matches what is displayed when running [root@power8-rhel73-3 ~]# ppc64_cpu --cores-present Number of cores present = 4 It seems that what is contained in /sys/devices/system/cpu/ is the maximum number of cores that the Power8 architecture can support (see Page 4 of https://www-01.ibm.com/common/ssi/cgi-bin/ssialias?htmlfid=POD03105USEN) – this is not necessarily the number of cores that the current machine has. That information is what's contained in /proc/cpuinfo. I think this makes sense, because when I try to run [root@power8-rhel73-3 ~]# ppc64_cpu --cores-on=all [root@power8-rhel73-3 ~]# ppc64_cpu --cores-on Number of cores _online_ = 4 I can only have 4 cores online, these being cpu0, cpu1, cpu2 and cpu3. If I try to set any other cpu online with ppc64_cpu, this will not work. Also, only cpus 0, 1, 2 and 3 have a positive physical_id – all other CPUs (5 - 159) have -1 for the physical id. So it looks like facter will have to consider those cpus with a positive physical id in https://github.com/puppetlabs/facter/blob/master/lib/src/facts/linux/processor_resolver.cc#L24-L33 to correctly report the Power8 info, in addition to what's written in the ticket. The code there would also need to avoid incrementing the logical_count every single time it encounters a cpu since on Power8, not every cpu in the /sys/devices/system/cpu/ is valid per the above discussion. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.