Jira (FACT-1760) test for "java_version" fails for "other systems" when java is not installed

[Sebastian Huebner (JIRA)]

Title: Message Title

Sebastian Huebner created an issue   Facter / FACT-1760 test for "java_version" fails for "other systems" when java is not installed Issue Type: Bug Affects Versions: FACT 3.9.0 Assignee: Unassigned Created: 2017/09/22 2:27 AM Environment: Tested on Debian 9.1, but should fail on every OS besides OpenBSD and Darwin Priority: Normal Reporter: Sebastian Huebner The test for "java_version" fails for "other systems" (i.e., everything besides OpenBSD and Darwin) when java is not installed: Facter::Util::Fact java_version returns java version when java present on OpenBSD should eq "1.7.0_71" on Darwin should eql "1.7.0_71" on other systems should eq "1.7.0_71" (FAILED - 1) returns nil when java not present on OpenBSD should be nil on Darwin should be nil on other systems should be nil   Failures:   1) Facter::Util::Fact java_version returns java version when java present on other systems should eq "1.7.0_71" Failure/Error: expect(Facter.value(:java_version)).to eq("1.7.0_71")   expected: "1.7.0_71" got: nil   (compared using ==) # ./spec/unit/facter/java_version_spec.rb:54:in `block (5 levels) in <top (required)>' As soon as Java is installed on the test system, the test succeeds. Reason: The fact uses Facter::Util::Resolution.which('java'), but that is not correctly mocked with Facter::Util::Resolution.expects(:which).with("java").returns(...) for the "other systems" test. The result of the test therefore depends on java being installed on the test system or not - obviously not the purpose of the test. Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.