Jira (PUP-8003) Update and test rubocop performance complaints Performance/Caller and Performance/CompareWithBlock

[Eric Delaney (JIRA)]

Title: Message Title

Eric Delaney created an issue   Puppet / PUP-8003 Update and test rubocop performance complaints Performance/Caller and Performance/CompareWithBlock Issue Type: Task Affects Versions: PUP 5.3.z Assignee: Unassigned Created: 2017/09/28 11:52 AM Priority: Normal Reporter: Eric Delaney While updating the rubocop version, I found 2 new rubocop checks that fail on the puppet code base that we should look at doing performance tests against to see if making the suggested change would have any performance improvements. Performance/Caller: rake aborted! RuboCop detected offenses /Users/eric.delaney/work/my_repos/puppet/Rakefile:75:in `block in <top (required)>' /Users/eric.delaney/.rvm/gems/ruby-2.3.3/gems/rake-12.0.0/exe/rake:27:in `<top (required)>' /Users/eric.delaney/.rvm/gems/ruby-2.3.3/bin/ruby_executable_hooks:15:in `eval' /Users/eric.delaney/.rvm/gems/ruby-2.3.3/bin/ruby_executable_hooks:15:in `<main>' Tasks: TOP => rubocop (See full trace by running task with --trace) == lib/puppet/util/log.rb == C:174: 58: Performance/Caller: Use caller(n..n) instead of caller[n]. == lib/puppet/util/logging.rb == C:203: 15: Performance/Caller: Use caller(n..n) instead of caller[n]. C:205: 16: Performance/Caller: Use caller(n..n) instead of caller[n].   1060 files inspected, 3 offenses detected Performance/CompareWithBlock rake aborted! RuboCop detected offenses /Users/eric.delaney/work/my_repos/puppet/Rakefile:75:in `block in <top (required)>' /Users/eric.delaney/.rvm/gems/ruby-2.3.3/gems/rake-12.0.0/exe/rake:27:in `<top (required)>' /Users/eric.delaney/.rvm/gems/ruby-2.3.3/bin/ruby_executable_hooks:15:in `eval' /Users/eric.delaney/.rvm/gems/ruby-2.3.3/bin/ruby_executable_hooks:15:in `<main>' Tasks: TOP => rubocop (See full trace by running task with --trace) == ext/puppet-test == C:438: 30: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. C:440: 41: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/application/describe.rb == C: 68: 17: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. C:153: 20: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. C:162: 27: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/application/doc.rb == C:157: 26: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/indirector/resource/ral.rb == C: 28: 9: Performance/CompareWithBlock: Use sort_by(&:title) instead of sort { |a, b| a.title <=> b.title }. == lib/puppet/provider/parsedfile.rb == C: 68: 17: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/reference/indirection.rb == C: 8: 45: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. C: 15: 61: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/reference/metaparameter.rb == C: 22: 12: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/reference/providers.rb == C: 38: 20: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/reference/type.rb == C: 52: 11: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. C: 72: 26: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. C: 95: 21: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/reports.rb == C: 77: 31: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/transaction/report.rb == C:335: 17: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/type/file.rb == C:577: 30: Performance/CompareWithBlock: Use sort_by { |a| a[:path] } instead of sort { |a, b| a[:path] <=> b[:path] }. == lib/puppet/type.rb == C:1908: 77: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/util/instance_loader.rb == C: 43: 28: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/util/metric.rb == C: 57: 13: Performance/CompareWithBlock: Use sort_by { |a| a[1] } instead of sort { |a, b| a[1] <=> b[1] }. == lib/puppet/util/provider_features.rb == C: 84: 28: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. C:133: 52: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }. == lib/puppet/util/reference.rb == C: 68: 34: Performance/CompareWithBlock: Use sort_by(&:to_s) instead of sort { |a, b| a.to_s <=> b.to_s }.   1060 files inspected, 24 offenses detected Add Comment   This message was sent by Atlassian JIRA (v6.4.14#64029-sha1:ae256fe) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.