Issue #3165 has been updated by Markus Roberts.

Status changed from Accepted to Code Insufficient

The code as submitted breaks three tests, and appears to have two mostly 
unrelated changes.

<pre>
1)
Mocha::ExpectationError in 'Puppet::Resource::Ral search should convert ral 
resources into regular resources'
unexpected invocation: #<Mock:my user resource>.to_resource()
satisfied expectations:
- allowed any number of times, already invoked once: 
#<Mock:request>.options(any_parameters)
- allowed any number of times, already invoked 3 times: 
#<Mock:request>.key(any_parameters)
- allowed any number of times, not yet invoked: #<Mock:my 
user>.name(any_parameters)
- allowed any number of times, already invoked once: #<Mock:my 
user>.to_resource(any_parameters)
- expected exactly once, already invoked once: 
Puppet::Type::User.instances(any_parameters)

/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:17:in
 `search'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:17:in
 `each'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:17:in
 `all?'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:17:in
 `search'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:14:in
 `each'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:14:in
 `find_all'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:14:in
 `search'
spec/unit/indirector/resource/ral_spec.rb:44:
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_methods.rb:40:in 
`instance_eval'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_methods.rb:40:in 
`execute'
/usr/lib/ruby/1.8/timeout.rb:53:in `timeout'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_methods.rb:37:in 
`execute'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:214:in
 `run_examples'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:212:in
 `each'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:212:in
 `run_examples'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:103:in
 `run'
/home/markus/projects/puppet/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:21:in
 `run'
/home/markus/projects/puppet/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:16:in
 `each'
/home/markus/projects/puppet/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:16:in
 `run'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/runner/options.rb:152:in 
`run_examples'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/runner.rb:61:in `run'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/runner.rb:45:
spec/unit/indirector/resource/ral_spec.rb:5:

2)
'Puppet::Resource::Ral search should filter results by query parameters' FAILED
expected: [#<Mock:wrong resource>],
     got: [] (using ==)
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/expectations/fail_with.rb:41:in 
`fail_with'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/matchers/operator_matcher.rb:39:in 
`fail_with_message'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/matchers/operator_matcher.rb:61:in 
`__delegate_operator'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/matchers/operator_matcher.rb:51:in 
`eval_match'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/matchers/operator_matcher.rb:29:in 
`=='
spec/unit/indirector/resource/ral_spec.rb:82:
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_methods.rb:40:in 
`instance_eval'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_methods.rb:40:in 
`execute'
/usr/lib/ruby/1.8/timeout.rb:53:in `timeout'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_methods.rb:37:in 
`execute'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:214:in
 `run_examples'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:212:in
 `each'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:212:in
 `run_examples'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:103:in
 `run'
/home/markus/projects/puppet/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:21:in
 `run'
/home/markus/projects/puppet/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:16:in
 `each'
/home/markus/projects/puppet/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:16:in
 `run'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/runner/options.rb:152:in 
`run_examples'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/runner.rb:61:in `run'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/runner.rb:45:
spec/unit/indirector/resource/ral_spec.rb:5:

3)
Mocha::ExpectationError in 'Puppet::Resource::Ral search should return sorted 
results'
unexpected invocation: #<Mock:bob resource>.[](:name)
satisfied expectations:
- allowed any number of times, not yet invoked: 
#<Mock:request>.options(any_parameters)
- allowed any number of times, not yet invoked: 
#<Mock:request>.key(any_parameters)
- allowed any number of times, not yet invoked: #<Mock:alice 
resource>.title(any_parameters)
- allowed any number of times, not yet invoked: #<Mock:alice 
resource>.to_resource(any_parameters)
- allowed any number of times, not yet invoked: #<Mock:bob 
resource>.title(any_parameters)
- allowed any number of times, already invoked once: #<Mock:bob 
resource>.to_resource(any_parameters)
- allowed any number of times, already invoked once: #<Mock:alice 
user>.to_resource(any_parameters)
- allowed any number of times, already invoked once: #<Mock:bob 
user>.to_resource(any_parameters)
- allowed any number of times, already invoked once: 
#<Mock:request>.options(any_parameters)
- allowed any number of times, already invoked 3 times: 
#<Mock:request>.key(any_parameters)
- expected exactly once, already invoked once: 
Puppet::Type::User.instances(any_parameters)

/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:17:in
 `search'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:17:in
 `each'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:17:in
 `all?'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:17:in
 `search'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:14:in
 `each'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:14:in
 `find_all'
/home/markus/projects/puppet/puppet/spec/../lib/puppet/indirector/resource/ral.rb:14:in
 `search'
spec/unit/indirector/resource/ral_spec.rb:101:
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_methods.rb:40:in 
`instance_eval'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_methods.rb:40:in 
`execute'
/usr/lib/ruby/1.8/timeout.rb:53:in `timeout'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_methods.rb:37:in 
`execute'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:214:in
 `run_examples'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:212:in
 `each'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:212:in
 `run_examples'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/example/example_group_methods.rb:103:in
 `run'
/home/markus/projects/puppet/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:21:in
 `run'
/home/markus/projects/puppet/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:16:in
 `each'
/home/markus/projects/puppet/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:16:in
 `run'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/runner/options.rb:152:in 
`run_examples'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/runner.rb:61:in `run'
/var/lib/gems/1.8/gems/rspec-1.3.0/lib/spec/runner.rb:45:
spec/unit/indirector/resource/ral_spec.rb:5:

Finished in 0.173122 seconds

8 examples, 3 failures
</pre>

----------------------------------------
Bug #3165: Ralsh can't manage files
https://projects.puppetlabs.com/issues/3165

Author: Jesse Wolfe
Status: Code Insufficient
Priority: Normal
Assignee: 
Category: ralsh
Target version: Statler
Affected version: 0.25.4
Keywords: training_bugs
Branch: 


<pre>
$ ralsh file filename
Could not run: Global resource access is deprecated
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to