Jira (PUP-8177) Older server version errors when an agent tries to download from the locales mountpoint

[Maggie Dreyer (JIRA)]

Title: Message Title

Maggie Dreyer created an issue   Puppet / PUP-8177 Older server version errors when an agent tries to download from the locales mountpoint Issue Type: Bug Assignee: Unassigned Created: 2017/11/13 4:12 PM Fix Versions: PUP 5.3.4 Priority: Normal Reporter: Maggie Dreyer As part of supporting module translations, we added a default mountpoint to Puppet for serving module translation files. However, this mountpoint will not be available on older versions of Puppetserver, so when an agent tries to query it, Puppetserver throws an error: Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/locales]: Failed to generate additional resources using 'eval_generate': Error 500 on SERVER: Server Error: Not authorized to call search on /file_metadata/locales with {:rest=>"locales", :links=>"follow", :recurse=>true, :source_permissions=>"ignore", :ignore=>[".svn", "CVS", ".git", ".hg", "*.pot", "config.yaml"], :checksum_type=>"sha256"} We need to handle this gracefully, since it is not really an error (it just means module translations won't be available agent-side). We cannot simply catch the exception, since at the downloader level the error has already been caught and logged as part of the HTTP handler. So ideally we should prevent the query from being made in the first place, dependent on the version of Puppetserver being queried. The server version is currently not available beyond the HTTP layer. Two options to explore for making it available include: 1) adding something to Puppet's context object 2) creating a setting to skip downloading locale files The context gives us a lifecycle for the data and tight control over it (no user can enable translation downloading by accident). However, a setting would give us the option to support people turning off translation downloads if they should prove problematic in certain use cases. Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.