Jira (PUP-8184) Remote filebuckets lose the leading slash

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on PUP-8184   Re: Remote filebuckets lose the leading slash It looks like webrick replaces all double-slashes in the request path with single slashes: https://github.com/ruby/ruby/blob/trunk/lib/webrick/httputils.rb#L35. So we get: (byebug) request.class WEBrick::HTTPRequest (byebug) request.request_uri.path "/puppet/v3/file_bucket_file/md5/a51e684e6db4917e16dd2802a8fb7d80//private/tmp/target" (byebug) request.path "/puppet/v3/file_bucket_file/md5/a51e684e6db4917e16dd2802a8fb7d80/private/tmp/target" Puppetserver is doing the same. I think the basic problem is we should be encoding the file path prior to adding it to the request path, otherwise the networking layer can't distinguish whether the second slash is another URI path separator or part of the file path at the application layer. Given puppet has always worked this way, and puppet doesn't do anything with the paths file, I'm going to close as won't fix. Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.