Jira (PUP-8181) break() fails with illegal context error within hash iteration outside any function

[Reid Wahl (JIRA)]

Title: Message Title

Reid Wahl commented on PUP-8181   Re: break() fails with illegal context error within hash iteration outside any function A hash doesn't rescue a `StopIteration` exception as an array does. There may very well be good reasons for this and maybe we can't simply go change the behavior. But using `each` loops as an example: each.rb: def foreach_Hash_1(hash) enumerator = hash.each_pair hash.size.times do yield(enumerator.next) end # produces the receiver hash end   def foreach_Hash_2(hash) enumerator = hash.each_pair hash.size.times do yield(*enumerator.next) end # produces the receiver hash end   def foreach_Enumerable_1(enumerable) enum = Puppet::Pops::Types::Iterable.asserted_iterable(self, enumerable) begin loop { yield(enum.next) } rescue StopIteration end # produces the receiver enumerable end   def foreach_Enumerable_2(enumerable) enum = Puppet::Pops::Types::Iterable.asserted_iterable(self, enumerable) index = 0 begin loop do yield(index, enum.next) index += 1 end rescue StopIteration end # produces the receiver enumerable end Tester code: $ cat ~nwahl/test.pp # test.pp   $my_array = ['a', 'b', 'c'] $my_hash = {'d' => 1, 'e' => 2, 'f' => 3}   $my_array.each |$var| { notice($var) break() notice("END") }   $my_hash.each |$key, $value| { notice($key) break() notice("END") } Puppet apply result: $ puppet apply ~nwahl/test.pp Notice: Scope(Class[main]): a Notice: Scope(Class[main]): d Error: break() from context where this is illegal at /u/nwahl/test.pp:14 on node <node> If I change it to rescue a StopIteration, the issue disappears: def foreach_Hash_1(hash) enumerator = hash.each_pair begin hash.size.times do yield(enumerator.next) end rescue StopIteration end # produces the receiver hash end   def foreach_Hash_2(hash) enumerator = hash.each_pair begin hash.size.times do yield(*enumerator.next) end rescue StopIteration end # produces the receiver hash end Puppet apply results: $ puppet apply ~nwahl/test.pp Notice: Scope(Class[main]): a Notice: Scope(Class[main]): d Notice: Compiled catalog for <node> in environment production in 0.11 seconds Notice: Applied catalog in 0.02 seconds Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.