Issue #5058 has been updated by Markus Roberts. Category set to error reporting Status changed from Unreviewed to Accepted Target version set to queued
Accepting on the basis of "we should handle this more gracefully, especially if the path is empty" but also noting that empty files are valid files (aka the Horton principle: "a file is a file, not matter how small") and thus just assuming that it's wrong based on the contents being empty would not be valid. ---------------------------------------- Bug #5058: Empty clientbucket files produce errors https://projects.puppetlabs.com/issues/5058 Author: Jordan Sissel Status: Accepted Priority: Normal Assignee: Category: error reporting Target version: queued Affected Puppet version: Keywords: Branch: I'm not sure how it happened, but I ended up with an empty clientbucket entry for one of my files. The 'contents' and 'paths' files were both present and empty. It caused this error: <pre> err: /Stage[main]/Os::Ubuntu/File[/etc/motd]/content: change from {md5}82cdaef7f3ba52467fb4e65491369889 to {md5}cd657ddfb4ff1e73910088a1d1c669ff failed: Could not back up /etc/motd: Got passed new contents for sum {md5}82cdaef7f3ba52467fb4e65491369889 </pre> Funky. Investigating, I see this: <pre> r...@solr00-2:/var/lib/puppet/clientbucket/8/2/c/d/a/e/f/7# ls -l 82cdaef7f3ba52467fb4e65491369889/ total 0 -r--r----- 1 root root 0 2010-10-20 03:20 contents -rw-r--r-- 1 root root 0 2010-10-20 03:20 paths </pre> This could have been caused (theoretically) by me killing puppet mid-run with a reboot or something similar, so I'm not convinced this the original problem is a bug in puppet. My request specifically is this: I think puppet should handle this case better. If the filebucket files are empty, it's might safe to discard them - especially if 'paths' is empty. Feel free to close this as "not a bug" if you feel such; it was a strange-enough behavior I felt it was worth sharing :) -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
