Jira (PUP-8204) loader.discover(:type) with --tasks on crashes because it tries to load rake tasks in puppet

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg created an issue   Puppet / PUP-8204 loader.discover(:type) with --tasks on crashes because it tries to load rake tasks in puppet Issue Type: Bug Assignee: Unassigned Created: 2017/11/22 3:26 PM Priority: Major Reporter: Henrik Lindberg The puppet code base has a directory named "tasks" that contains rake tasks. When trying to discover all data types and --tasks is on, the loader will try to load those as if they were instances of Task. This fails miserably in task_instantiator with the following stack trace: {çode} Failure/Error: constants['executable'] = Pathname(task_source).relative_path_from(Pathname(loader.path) + 'tasks').to_s Puppet::Error: no implicit conversion of nil into String on node henrik2 ./lib/puppet/pops/loader/task_instantiator.rb:95:in `initialize' ./lib/puppet/pops/loader/task_instantiator.rb:95:in `Pathname' ./lib/puppet/pops/loader/task_instantiator.rb:95:in `create_task_type_from_hash' ./lib/puppet/pops/loader/task_instantiator.rb:31:in `create_task_type' ./lib/puppet/pops/loader/task_instantiator.rb:26:in `create' ./lib/puppet/pops/loader/module_loaders.rb:222:in `instantiate' ./lib/puppet/pops/loader/module_loaders.rb:198:in `find' ./lib/puppet/pops/loader/base_loader.rb:161:in `internal_load' ./lib/puppet/pops/loader/base_loader.rb:42:in `load_typed' ./lib/puppet/pops/loader/module_loaders.rb:117:in `block (2 levels) in discover' ./lib/puppet/pops/loader/module_loaders.rb:114:in `each' ./lib/puppet/pops/loader/module_loaders.rb:114:in `block in discover' ./lib/puppet/pops/loader/module_loaders.rb:113:in `each' ./lib/puppet/pops/loader/module_loaders.rb:113:in `discover' ./lib/puppet/pops/loader/base_loader.rb:28:in `discover' ./lib/puppet/pops/loader/module_loaders.rb:121:in `discover' ./lib/puppet/pops/loader/dependency_loader.rb:28:in `block in discover' ./lib/puppet/pops/loader/dependency_loader.rb:28:in `each' ./lib/puppet/pops/loader/dependency_loader.rb:28:in `discover' ./lib/puppet_pal.rb:213:in `list_loadable_kind' ./lib/puppet_pal.rb:265:in `list_tasks' ./spec/unit/puppet_pal_2pec.rb:674:in `block (7 levels) in <top (required)>' ./lib/puppet_pal.rb:611:in `call' ./lib/puppet_pal.rb:611:in `block (2 levels) in main' ./lib/puppet/parser/script_compiler.rb:47:in `block in compile' ./lib/puppet/context.rb:65:in `override' ./lib/puppet.rb:263:in `override' ./lib/puppet/parser/script_compiler.rb:42:in `compile' ./lib/puppet_pal.rb:609:in `block in main' ./lib/puppet/context.rb:65:in `override' ./lib/puppet.rb:263:in `override' ./lib/puppet_pal.rb:578:in `main' ./lib/puppet_pal.rb:341:in `block in with_script_compiler' ./lib/puppet/context.rb:65:in `override' ./lib/puppet.rb:263:in `override' ./lib/puppet_pal.rb:338:in `with_script_compiler' ./spec/unit/puppet_pal_2pec.rb:674:in `block (6 levels) in <top (required)>' ./lib/puppet_pal.rb:506:in `call' ./lib/puppet_pal.rb:506:in `block in in_environment_context' ./lib/puppet/context.rb:65:in `override' ./lib/puppet.rb:263:in `override' ./lib/puppet_pal.rb:498:in `in_environment_context' ./lib/puppet_pal.rb:398:in `in_tmp_environment' ./spec/unit/puppet_pal_2pec.rb:673:in `block (5 levels) in <top (required)>' It fails because loader.path is nil. The real problem is that it should not try to load tasks from puppet in that location. Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.