Issue #3420 has been updated by Bruce Richardson. Status changed from Investigating to Needs design decision Target version set to queued
OK, then since I do have some questions and I'm not sure about what status decisions I can make, I'll update this to "Needs design decision". The requested design decision is this: regardless of the quality of my proposed patch, is it acceptable to move from the current situation, where the "name" property of nagios objects cannot be generated, to a situation where it is always generated. It works for *me*, because I want the functionality blocked by the bug. There is, though, a chance of the new behaviour breaking existing Puppet+Nagios installations; since it is not currently possible to generate Nagios object templates from Puppet resources, people who want them must have created their templates via a different route. This means there's a chance of creating an unexpected duplicate name - which would cause Nagios to halt. To be honest, I think that risk is enough to merit a little more work on the patch, to make at least some minimal change to external/nagios/base.rb to add a toggle. But asking the question gives me the chance to ask one or two questions about the process: 1. Who decides what the target branch will be and at what stage is that done? 2. How is "Affected Version" updated? Is that via a keyword? If you surprise me and say the functionality change caused by my current patch is acceptable, I'll push it through the development workflow. ---------------------------------------- Bug #3420: Nagios "name" attribute not output correctly https://projects.puppetlabs.com/issues/3420 Author: Robin Skoglund Status: Needs design decision Priority: Normal Assignee: Bruce Richardson Category: Target version: queued Keywords: Branch: I think I've stumbled upon a bug in the way Naginator outputs the Nagios "name" attribute. I have the following `nagios_service` type defined in a manifest: <pre> nagios_service { "jmx-${name}": use => "basic-service", service_description => "JMX $name", check_command => "check_jmx_heap_via_ssh!$name", register => "0", target => "/usr/local/nagios/etc/generated_services/$name.cfg" } </pre> Expected output: <pre> define service { check_command check_jmx_heap_via_ssh!kidkalkulator register 0 name jmx-kidkalkulator service_description JMX kidkalkulator use basic-service } </pre> Actual output: <pre> define service { check_command check_jmx_heap_via_ssh!kidkalkulator register 0 ## --PUPPET_NAME-- (called '_naginator_name' in the manifest) jmx-kidkalkulator-test service_description JMX kidkalkulator use basic-service } </pre> I attached a patch that changes `puppet/provider/naginator.rb` to output as expected, but I am not sure whether the patch will break other parts of Naginator/puppet. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
