Jira (PUP-8225) An "environment" fact will overwrite values from the ENC in Puppet 5

[Charlie Sharpsteen (JIRA)]

Title: Message Title

Charlie Sharpsteen created an issue   Puppet / PUP-8225 An "environment" fact will overwrite values from the ENC in Puppet 5 Issue Type: Bug Affects Versions: PUP 5.3.3 Assignee: Unassigned Components: Platform Created: 2017/12/04 12:14 PM Priority: Critical Reporter: Charlie Sharpsteen Puppet 5 fixed an issue where stale facts were used for catalog requests if a master had a cold cache ( PUP-3438 and PUP-7198 ). The fix was to merge facts submitted by the agent back into the node object instead of pulling facts from the cache. However, the merge is overwriting the environment returned by the ENC, which causes nodes to behave incorrectly if an environment fact is present. Reproduction Case Install PE 2017.3.2. Log into the PE console and verify that the classifier sets the master node environment to production via the "Production environment" Environment Group. Copy the production environment to a new directory environment called facter_env: cp -r /etc/puppetlabs/code/environments/production /etc/puppetlabs/code/environments/facter_env chown -R pe-puppet /etc/puppetlabs/code/ Set environment and as an external fact: mkdir -p /etc/facter/facts.d   cat << 'EOF' > /etc/facter/facts.d/facter_facts.txt environment=facter_env EOF Run puppet agent -t Outcome The agent switches to facter_env despite the ENC setting: [root@pe-201732-master production]# puppet agent -t Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for pe-201732-master.puppetdebug.vlan   Notice: Local environment: 'production' doesn't match server specified environment 'facter_env', restarting agent run with environment 'facter_env'   Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for pe-201732-master.puppetdebug.vlan Info: Applying configuration version '1512410109' Notice: Applied catalog in 13.11 seconds Expected Outcome The agent should stay in production: [root@pe-201732-master production]# puppet agent -t   Info: Using configured environment 'production'   Info: Retrieving pluginfacts Info: Retrieving plugin Info: Loading facts Info: Caching catalog for pe-201732-master.puppetdebug.vlan Info: Applying configuration version '1512409900' Notice: Applied catalog in 12.26 seconds Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.