Jira (PUP-8247) Parser locator doesn't cache anything and doesn't appear to work.

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-8247 Parser locator doesn't cache anything and doesn't appear to work. Issue Type: Task Assignee: Unassigned Created: 2017/12/13 1:29 PM Priority: Normal Reporter: Josh Cooper The Puppet::Pops::Parser::Locator attempts to cache line location information, but it ends up calling local variables prev_line etc that shadow the accessor methods of the same name. Even after fixing the code, e.g. self.prev_offset = offset self.prev_line = line_nbr The caching mechanism does not appear to work even when using unlimited environment timeouts. Given a manifest: file { '/tmp/testing': ensure => present, } I get the following instrumented output which shows it keeps getting cache misses: Debug: Evaluating match for Route /.*/ Notice: Locator cache miss offset=25 => line number=2 Notice: Locator cache miss offset=0 => line number=1 Notice: Compiled catalog for localhost in environment production in 0.00 seconds This ticket is to fix the cache implementation and add tests that it works. Currently the Locator unit tests only show that it can handle multibyte input. Second issue is we seem to collect locator information for puppet data types on every request. Since those are immutable, why not do that once and freeze the results for the lifetime of the process? Notice: Locator string=Annotation, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Any, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::CatalogEntryType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarDataType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::NumericType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarDataType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarDataType, file=, index=, char_offsets=false Notice: Locator string=Pcore::NumericType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarDataType, file=, index=, char_offsets=false Notice: Locator string=Pcore::CollectionType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::StructElement, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarDataType, file=, index=, char_offsets=false Notice: Locator string=Pcore::ScalarType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::CollectionType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::CatalogEntryType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Pcore::AnyType, file=, index=, char_offsets=false Notice: Locator string=Puppet::Resource::Param, file=, index=, char_offsets=false Notice: Locator string=Puppet::Resource::Param, file=, index=, char_offsets=false Notice: Locator string=Any, file=, index=, char_offsets=false Notice: Locator string=RichDataKey, file=, index=, char_offsets=false Notice: Locator string=RichData, file=, index=, char_offsets=false Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.