Jira (PUP-8301) Puppet::Type.eachtype raises an error instead of returning nil of no types are loaded

[Glenn Sarti (JIRA)]

Title: Message Title

Glenn Sarti created an issue   Puppet / PUP-8301 Puppet::Type.eachtype raises an error instead of returning nil of no types are loaded Issue Type: Bug Affects Versions: PUP 5.3.3 Assignee: Unassigned Created: 2017/12/30 5:09 AM Environment: Using ruby to load types on demand (Puppet VSCode extensions) Priority: Trivial Reporter: Glenn Sarti While writing some code for the VS Code Extension I came across a simple error If no types had been loaded yet then calls to 'Puppet::Type.eachtype' fail with NoMethodError: undefined method `each' for nil:NilClass from C:/Source/puppet-vscode/server/.bundle/windows/ruby/2.3.0/gems/puppet-4.10.1-x64-mingw32/lib/puppet/metatype/manager.rb:39:in `eachtype' This is due to the instance variable @types only being set upon the first module that gets loaded. The clear_misses method has nil detection but not eachtype https://github.com/puppetlabs/puppet/blob/892d7a9252698e44cde936b7334fca05952a4079/lib/puppet/metatype/manager.rb#L38-L45 Recommended solution: Add a return if @types.nil? as the first line in the method. This is a fairly low importance and low incidence as I'm using Puppet in a not a normal way but it's still a bug in the behaviour. Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.