Jira (PUP-8347) Find more places where we report the file or line information and convert them to use error_location()

[Eric Delaney (JIRA)]

Title: Message Title

Eric Delaney created an issue   Puppet / PUP-8347 Find more places where we report the file or line information and convert them to use error_location() Issue Type: Task Assignee: Unassigned Created: 2018/01/11 2:46 PM Priority: Normal Reporter: Eric Delaney We need to grep the puppet code base and find more of the locations that we report the file and line location information for an error and use the Puppet::Util::Errors.error_location() method to create the string so we are consistent. For example: $ grep -r 'at line' lib lib/puppet/settings/config_file.rb: raise(Puppet::Error, _("Illegal section '%{name}' in config file %{file} at line %{line}. The only valid puppet.conf sections are: [%{allowed_sections}]. Please use the directory environments feature to specify environments. (See https://docs.puppet.com/puppet/latest/reference/environments.html)") % { name: section.name, file: file, line: section.line_number, allowed_sections: allowed_section_names.join(", ") }) lib/puppet/pops/validation.rb: " at line #{line}:#{pos}" lib/puppet/pops/validation.rb: " at line #{line}" lib/puppet/pops/issues.rb: fl ? _("%{msg}. First defined at line %{line}") % { msg: msg, line: fl } : msg lib/puppet/pops/issues.rb: fl ? _("%{msg}. First defined at line %{line}") % { msg: msg, line: fl } : msg lib/puppet/util/network_device/config.rb: raise Puppet::Error, _("Duplicate device found at line %{count}, already found at %{line}") % { count: count, line: device.line } if devices.include?(name) lib/puppet/util/network_device/config.rb: raise Puppet::Error, _("Invalid argument '%{var}' at line %{count}") % { var: var, count: count } lib/puppet/network/auth_config_parser.rb: raise Puppet::ConfigurationError, _("Missing or invalid 'path' before right directive at line %{count} of %{file}") % { count: count, file: @file } lib/puppet/network/auth_config_parser.rb: _("Invalid argument '%{var}' at line %{count}") % { var: var, count: count } lib/puppet/network/auth_config_parser.rb: raise Puppet::ConfigurationError, _("%{detail} at line %{count} of %{file}") % { detail: detail, count: count, file: @file }, detail.backtrace lib/puppet/provider/package/gem.rb: # but when it's not to the console that line lib/puppet/type/ssh_authorized_key.rb: to split that line into several attributes. Thus, a key that appears in $ Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.