Jira (PUP-8374) NameService inconsistent with setting the environment in which commands are executed

[Melissa Stone (JIRA)]

Title: Message Title

Melissa Stone created an issue   Puppet / PUP-8374 NameService inconsistent with setting the environment in which commands are executed Issue Type: Bug Assignee: Unassigned Created: 2018/01/19 3:57 PM Priority: Normal Reporter: Melissa Stone When we execute commands to create, set, and modify something on the system, we should be maintaining a consistent environment. Currently, when we create that thing, we're passing in a custom environment 167 def create 168 if exists? 169 info _("already exists") 170 # The object already exists 171 return nil 172 end 173 174 begin 175 execute(self.addcmd, {:failonfail => true, :combine => true, :custom_environment => @custom_environment}) 176 if feature?(:manages_password_age) && (cmd = passcmd) 177 execute(cmd) 178 end 179 rescue Puppet::ExecutionFailure => detail 180 raise Puppet::Error, _("Could not create %{resource} %{name}: %{detail}") % { resource: @resource.class.name, name: @resource.name, detail: detail }, detail.backtrace 181 end 182 end but not when we set or delete with the same command 184 def delete 185 unless exists? 186 info _("already absent") 187 # the object already doesn't exist 188 return nil 189 end 190 191 begin 192 execute(self.deletecmd) 193 rescue Puppet::ExecutionFailure => detail 194 raise Puppet::Error, _("Could not delete %{resource} %{name}: %{detail}") % { resource: @resource.class.name, name: @resource.name, detail: detail }, detail.backtrace 195 end 196 end . . . 299 def set(param, value) 300 self.class.validate(param, value) 301 cmd = modifycmd(param, munge(param, value)) 302 raise Puppet::DevError, _("Nameservice command must be an array") unless cmd.is_a?(Array) 303 begin 304 execute(cmd) 305 rescue Puppet::ExecutionFailure => detail 306 raise Puppet::Error, _("Could not set %{param} on %{resource}[%{name}]: %{detail}") % { param: param, resource: @resource.class.name, name: @resource.name, detail: detail }, detail.backtrace 307 end 308 end All of these execution environments should be consistent, if that is the desired behavior defined in the provider. Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.