Jira (PUP-8407) Puppet benchmarks fail due to gettext-setup initialization

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-8407 Puppet benchmarks fail due to gettext-setup initialization Issue Type: Bug Assignee: Unassigned Created: 2018/01/30 11:11 AM Fix Versions: PUP 5.3.5 Priority: Normal Reporter: Josh Cooper Puppet Version: 5.3.x Puppet Server Version: n/a Running puppet benchmarks fails: $ bx rake benchmark:many_modules:run mkdir -p /var/folders/8m/d6146zxd6bv_3h8y4ykvvxh40000gn/T/many_modules20180130-73932-2mw6bc user system total real Run 1 rake aborted! no implicit conversion of nil into String /Users/josh/work/puppet/lib/puppet/module.rb:316:in `join' /Users/josh/work/puppet/lib/puppet/module.rb:316:in `has_translations?' /Users/josh/work/puppet/lib/puppet/gettext/module_translations.rb:12:in `block in load_from_modulepath' /Users/josh/work/puppet/lib/puppet/gettext/module_translations.rb:11:in `each' /Users/josh/work/puppet/lib/puppet/gettext/module_translations.rb:11:in `load_from_modulepath' /Users/josh/work/puppet/lib/puppet/node/environment.rb:444:in `use_text_domain' /Users/josh/work/puppet/lib/puppet/indirector/catalog/compiler.rb:52:in `find' The issue is that puppet sets FastGettext.default_available_locales to nil to prevent FastGettext from selecting the best available default locale. Later puppet's Rakefile loads the gettext-setup gem. It sets FastGettext.default_available_locales to empty string (instead of nil). This activates the "available locales" machinery in FastGettext. Then GettextSetup.initialize tries to set the default locale, which due to the empty array causes the default locale to be set to nil. (byebug) best_locale_in(new_locale) nil (byebug) new_locale "en" This is only an issue when running puppet via the Rakefile, e.g. benchmarks and rake parallel:spec, not when puppet is running from source, e.g. bundle exec puppet agent or from packages. Add Comment   This message was sent by Atlassian JIRA (v7.0.2#70111-sha1:88534db) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.