Issue #1220 has been updated by Nigel Kersten.

Status changed from Accepted to Closed

This was fixed. I had the same problem due to using UUIDs as certnames rather 
than hostnames.
----------------------------------------
Bug #1220: fileserver.conf (parsed by network/authstore.rb) will not accept 
single-word hostnames (et al)
https://projects.puppetlabs.com/issues/1220

Author: technogeeky -
Status: Closed
Priority: Normal
Assignee: technogeeky -
Category: Debian
Target version: 
Patch: Insufficient
Affected Puppet version: 0.25.4
Keywords: 
Branch: 


The parser for fileserver.conf does not have a case allowing a single-word 
hostname to be used like it does for fully-qualified domain names, wildcards, 
and IP addresses.

Example of an "invalid" fileserver.conf:
<pre>
[files]
path /to/files
allow foo
</pre>

The FQDN regex won't allow this because it requires a period (".") to match.

There are probably arguments against allowing someone to put a single-word 
hostname in the fileserver.conf, but many simpler configurations will encounter 
this.

My patch (to be attached) does *not* allow wildcard matching on a single 
hostname. My reasoning for this decision is based on security: whereas an 
accidental asterisk ("*") in a FQDN may cause unintentional access rights to be 
granted/denied, such an error in a single-word hostname could have tremendously 
worse effects.

Additionally, I have changed the two nearby regexes which would not match on 
some allowed (and used, in my case) domains which start with numbers 
(00hostname.invalid). Additionally, I modified the rest of the regex to comply 
with the stanard "starting and ending in alphanumerics without dashes" 
description of the hostname/DNS RFCs.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to