Jira (BOLT-332) Target objects should store state of the Targets

Alex Dreyer (JIRA) Wed, 14 Feb 2018 09:59:54 -0800

Title: Message Title

Alex Dreyer commented on

We have a `Target` datatype that is returned by `get_targets` already. Our plan is to add `set_var` and `vars` onto the datatype.

In practice this is what we want

$t1  = get_target('mynode)

$t2 = get_target('mynode')

# to a lesser extent $t3 = Target('mynode')

$t1.set_var('foo', 10)

assert($t2.vars['foo'] == 10)

Wether that is accomplished by get_target returning the same instance and set_var mutating the instance or set_var/vars accessing global state doesn't seem particularly important.
I would not expect 'mynode'.set_var(foo, 10) to work.

Not specifically target related:
Why must values be immutable in the plan language? In order to resolve the references in a declarative catalog permanent binding and immutable values make sense but during plan execution it doesn't seem as valuable.

For a plan language to attracts non-puppet users I think we need to accept some level of mutability. I've written a lot of clojure and prolog and it's still annoying for me.

$result = {}

$result = $result.set('first_run', run_task('foo', $nodes))

$nodes.each |$n| {

  $result = $result.merge("$node_run" => run_task('bar', $n))

and/or

$result = MutableHash()

$result.set('first_run', run_task('foo', $nodes))

$nodes.each |$n| {

  $result.set("$node_run", run_task('bar', $n))

Mutable objects seems like the simpler solution here.

For example I don't think we'll have a satisfactory while statement without mutability.

$results = MultableArray()

while {

  $results.append(run_task('check', $node).first['val']

  if $result.last < 5 {

   break

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (BOLT-332) Target objects should store state of the Targets

Reply via email to