Jira (PUP-8499) puppet lookup cli, using --facts and --node simultaneously breaks

Title: Message Title

Just commented on

After looking at the code, I found the problem seemed to be here, in puppet/application/lookup.rb :

def generate_scope

 if options[:node]

   node = options[:node]

 else

   node = Puppet[:node_name_value]

   # If we want to lookup the node we are currently on

   # we must returning these settings to their default values

   Puppet.settings[:facts_terminus] = 'facter'

end

For some reason, not setting

Puppet.settings[:facts_terminus] = 'facter'

breaks the

node.add_extra_facts

I don't know whey, I'm not really too familiar with the code.

If you change the code to do

Puppet.settings[:facts_terminus] = 'facter'

..whether you specify the node option or not, it doesn't break.

So I don't know if this is a real solution, but the attached patch fixes the error and returns data correctly as far as I can tell.

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Reply via email to