Jira (PDOC-224) puppet-strings 1.2.0 breaks --emit-json-stdout

[Ewoud Kohl van Wijngaarden (JIRA)]

Title: Message Title

Ewoud Kohl van Wijngaarden created an issue   Puppet Strings / PDOC-224 puppet-strings 1.2.0 breaks --emit-json-stdout Issue Type: Bug Assignee: Unassigned Created: 2018/03/01 4:26 AM Priority: Normal Reporter: Ewoud Kohl van Wijngaarden With puppet-strings 1.2.0 $ puppet strings generate --emit-json-stdout ~/dev/puppet-tftp/manifests/init.pp WARNING: '--emit-json-stdout' is deprecated. Use '--format json' instead. 100.00% documented With puppet-strings 1.1.0 $ puppet strings generate --emit-json-stdout ~/dev/puppet-tftp/manifests/init.pp {   "puppet_classes": [     {       "name": "tftp",       "file": "/home/ekohl/dev/puppet-tftp/manifests/init.pp",       "line": 28,       "docstring": {         "text": "TFTP server class\n\nThis class installs and configures a TFTP server, supporting both standalone\ndaemons and xinetd-based TFTP servers.",         "tags": [           {             "tag_name": "summary",             "text": "Installs and configures a TFTP server"           },           {             "tag_name": "example",             "text": "include tftp",             "name": "Simple usage"           },           {             "tag_name": "example",             "text": "class { 'tftp':\n  root => '/tftpboot',\n}",             "name": "Configure a TFTP server with a non-default root directory"           },           {             "tag_name": "example",             "text": "class { 'tftp:'\n  package => 'tftp-hpa-destruct',\n}",             "name": "Configure a TFTP server with non-default package name"           },           {             "tag_name": "param",             "text": "Configures the root directory for the TFTP server",             "types": [               "Stdlib::Absolutepath"             ],             "name": "root"           },           {             "tag_name": "param",             "text": "Name of the TFTP server package",             "types": [               "String"             ],             "name": "package"           },           {             "tag_name": "param",             "text": "Name of the syslinux package, essential for pxe boot",             "types": [               "Variant[String, Array[String]]"             ],             "name": "syslinux_package"           },           {             "tag_name": "param",             "text": "Runs a TFTP service when true, configures xinetd when false",             "types": [               "Boolean"             ],             "name": "daemon"           },           {             "tag_name": "param",             "text": "manages the root dir, which tftpd will serve, defaults to true",             "types": [               "Boolean"             ],             "name": "manage_root_dir"           },           {             "tag_name": "param",             "text": "Name of the TFTP service, when daemon is true",             "types": [               "Optional[String]"             ],             "name": "service"           },           {             "tag_name": "param",             "text": "Override TFTP service provider, when daemon is true",             "types": [               "Optional[String]"             ],             "name": "service_provider"           }         ]       },       "defaults": {         "service": "undef",         "service_provider": "undef"       },       "source": "class tftp (\n  Stdlib::Absolutepath $root,\n  String $package,\n  Variant[String, Array[String]] $syslinux_package,\n  Boolean $daemon,\n  Boolean $manage_root_dir,\n  Optional[String] $service = undef,\n  Optional[String] $service_provider = undef,\n) {\n\n  class {'::tftp::install':}\n  -> class {'::tftp::config':}\n  ~> class {'::tftp::service':}\n  -> Class['::tftp']\n}"     }   ],   "defined_types": [     ],   "resource_types": [     ],   "providers": [     ],   "puppet_functions": [     ] }   If a class has undocumented parameters, --emit-json-stdout also puts warnigs on stdout rather than stderr which would also break JSON parsing. In kafo_parsers we call with --emit-json-stdout. We can't detect the exact puppet-strings version easily and maintaining compatibility with older versions is useful. We can redirect stderr to `/dev/null` so that'd be a good compromise. The exact call Add Comment   This message was sent by Atlassian JIRA (v7.5.1#75006-sha1:7df2574) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.