Jira (PUP-8442) type parameters do not honor when default is set to false

Josh Cooper (JIRA) Fri, 02 Mar 2018 11:39:15 -0800

Title: Message Title

Josh Cooper commented on

We had to revert this change because the vcsrepo 1.2.0 module defines a "generic" force parameter:

  newparam :force do

    desc "Force repository creation, destroying any files on the path in the process."

    newvalues(:true, :false)

    defaultto false

end

Older versions of puppet cause the parameter value to be set to nil, :false or :true, where nil is the default, and the latter two occur if the value is set explicitly in a manifest as "false" or "true", respectively.

With the above change, the provider's default false becomes :false, which in ruby is truthy. This causes the vcsrepo type to think force has been set to true and it will attempt to delete the local repo on each run.

The incorrect boolean handling in the vcsrepo was fixed in https://github.com/puppetlabs/puppetlabs-vcsrepo/commit/b581a255161fe7fd5d6d264b5c0274ccb852cdcd

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-8442) type parameters do not honor when default is set to false

Reply via email to