Jira (PUP-8443) Topscope 'environment' can become nil when setting node parameters in a custom terminus

Melissa Stone (JIRA) Tue, 13 Mar 2018 12:39:30 -0700

Title: Message Title

I've manually validated this. First I verified I could reproduce this issue in puppet-agent 5.3.4, and then validated it was fixed in puppet-agent 5.4.0.489.gc5e2622

I tested by changing the `find` method in lib/puppet/indirector/node/plain.rb

  def find(request)

    node = super

    node.environment = request.environment

    node.environment = 'foo'

    facts = request.options[:facts].is_a?(Puppet::Node::Facts) ? request.options[:facts] : nil

    node.fact_merge(facts)

    node.parameters['evironment'] = 'bar'

    node

end

running
{{puppet apply -e " file

{'/tmp/foo': ensure => present, content => \"environment is '$::environment'\n\" }

"}}

and then verifying the contents of /tmp/foo
puppet-agent 5.3.4:

# cat /tmp/foo

environment is 'bar'

puppet-agent 5.4.0.489.gc5e2622:

# cat /tmp/foo

environment is 'foo'

In puppet-agent 5.4.0.489.gc5e2622, environment is correctly being set to 'foo', whereas in puppet-agent 5.3.4 it is not.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (PUP-8443) Topscope 'environment' can become nil when setting node parameters in a custom terminus

Reply via email to