Jira (PUP-8549) Reduce regular expression garbage in puppet

[Justin Stoller (JIRA)]

Title: Message Title

Justin Stoller commented on PUP-8549   Re: Reduce regular _expression_ garbage in puppet Testing how external encoding of puppet cli applications affect tags: justin$ LANG=en_US.iso8859-1 bundle exec puppet resource exec /bin/ls tries=3   Created tag via Puppet::Resource#tag of exec with encoding ISO-8859-1 Requested to create tag via Puppet::Resource#tag_if_valid of /bin/ls with encoding ISO-8859-1 NOT creating tag /bin/ls Created tag via Puppet::Resource#tag of file with encoding US-ASCII Requested to create tag via Puppet::Resource#tag_if_valid of /bin/ls with encoding ISO-8859-1 NOT creating tag /bin/ls Created tag via Puppet::Resource#tag of exec with encoding US-ASCII Requested to create tag via Puppet::Resource#tag_if_valid of /bin/ls with encoding ISO-8859-1 NOT creating tag /bin/ls Created tag via Puppet::Transaction::Event#tag of exec with encoding ISO-8859-1 Created tag via Puppet::Util::Log#tag of notice with encoding US-ASCII Created tag via Puppet::Util::Log#tag of exec with encoding ISO-8859-1 Notice: /Exec[/bin/ls]/returns: executed successfully Created tag via Puppet::Resource#tag of exec with encoding US-ASCII Requested to create tag via Puppet::Resource#tag_if_valid of /bin/ls with encoding ISO-8859-1 NOT creating tag /bin/ls exec { '/bin/ls':   returns => 'notrun', } One of the questions in the PR was whether or not the direct creation of a Resource in this test case was a valid reproduction of how strings used by the resource application could be tagged. It actually is, where if a resource without parameters is queried it will use the indirector, while if parameters are used with the resource the application will directly create a Resource and save it (See here). Note, with the direct creation of a Resource above the type is also in the external encoding (and as US-ASCII), while below in the no-params case, where we use the indirector, only the title is tagged in the external encoding. justin$ LANG=en_US.iso8859-1 bundle exec puppet resource exec /bin/ls   Created tag via Puppet::Resource#tag of exec with encoding US-ASCII Requested to create tag via Puppet::Resource#tag_if_valid of /bin/ls with encoding ISO-8859-1 NOT creating tag /bin/ls Created tag via Puppet::Resource#tag of exec with encoding US-ASCII Requested to create tag via Puppet::Resource#tag_if_valid of /bin/ls with encoding ISO-8859-1 NOT creating tag /bin/ls exec { '/bin/ls':   returns => 'notrun', } Just to clarify, the test itself is testing that differently encoded strings returned from the system are coerced into the default external encoding when output to the user (maybe double bookkeeping that  these calls to force_encoding exist). Which is different than if input in non-UTF-8 compatible default external encodings reaches the tagging helpers (which is what I was considering for the purpose of this work and seems to be true). Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.