Jira (PUP-8240) ERB and EPP templates handle CRLF line endings inconsistently

[Glenn Sarti (JIRA)]

Title: Message Title

Glenn Sarti commented on PUP-8240   Re: ERB and EPP templates handle CRLF line endings inconsistently The file loader at; https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/parser/lexer2.rb#L650 is stripping the CRLF and comes in as LF only From: C:/Source/tmp/PUP-8240/.bundle/windows/ruby/2.3.0/gems/puppet-5.5.0-x64-mingw32/lib/puppet/pops/parser/lexer2.rb @ line 651 Puppet::Pops::Parser::Lexer2#lex_file:   648: def lex_file(file) 649: initvars 650: contents = Puppet::FileSystem.exist?(file) ? Puppet::FileSystem.read(file, :encoding => 'utf-8') : '' => 651: assert_not_bom(contents) 652: @scanner = StringScanner.new(contents.freeze) 653: @locator = Locator.locator(contents, file) 654: end [6] pry(#<Puppet::Pops::Parser::Lexer2>)> contents => "line 1\nline 2\n:P" [7] pry(#<Puppet::Pops::Parser::Lexer2>)> file => "c:/source/tmp/PUP-8240/test.epp" [8] pry(#<Puppet::Pops::Parser::Lexer2>)> Perhaps use read_preserve_line_endings or binread https://github.com/puppetlabs/puppet/blob/master/lib/puppet/file_system.rb#L151-L161 Note that the ERB loader uses read_preserve_line_endings https://github.com/puppetlabs/puppet/blob/master/lib/puppet/parser/templatewrapper.rb#L74 Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.