Jira (PUP-8586) Feature related debug messages are confusing and generate too much spam

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-8586 Feature related debug messages are confusing and generate too much spam Issue Type: Task Assignee: Unassigned Created: 2018/03/22 10:13 AM Priority: Normal Reporter: Josh Cooper During an agent run, if a feature is not available, notably msgpack, we print a scary looking message: Debug: Dynamically-bound server lookup failed, falling back to server setting Debug: Dynamically-bound port lookup failed; falling back to masterport setting Debug: Failed to load library 'msgpack' for feature 'msgpack': cannot load such file -- msgpack Debug: Puppet::Network::Format[msgpack]: feature msgpack is missing Debug: file_metadata supports formats: json pson yaml The "Failed to load library" sounds bad, but it isn't. It just means an optional feature isn't enabled, which is the normal/default case. We should make the message less scary. We should only emit the message once, not everytime we make a file_metadata request. Similarly, the "Dynamically-bound server" and "port" messages are repeated for every file_metadata request. Similarly, if a type's property/parameter depends on a provider feature, and that provider feature isn't available, we repeat the same set of messages for every instance of that resource type. I think we should only emit the message once per resource type (and possibly once if the feature becomes true later in the run if the command, feature, etc becomes available): Debug: /Firewall[a]: Provider iptables does not support features hop_limiting; not managing attribute hop_limit Debug: /Firewall[a]: Provider iptables does not support features ishasmorefrags; not managing attribute ishasmorefrags Debug: /Firewall[a]: Provider iptables does not support features islastfrag; not managing attribute islastfrag Debug: /Firewall[a]: Provider iptables does not support features isfirstfrag; not managing attribute isfirstfrag ... Debug: /Firewall[b]: Provider iptables does not support features hop_limiting; not managing attribute hop_limit Debug: /Firewall[b]: Provider iptables does not support features ishasmorefrags; not managing attribute ishasmorefrags Debug: /Firewall[b]: Provider iptables does not support features islastfrag; not managing attribute islastfrag Debug: /Firewall[b]: Provider iptables does not support features isfirstfrag; not managing attribute isfirstfrag Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.