Issue #5079 has been updated by Matt Robinson. Status changed from Rejected to Code Insufficient Assignee changed from Nigel Kersten to Sandor Szücs
After reviewing the patch further, it looks like the changes were good, it was just really hard to tell from the diff that they were good. I've responded on the mailing list with an example of how the patch could be presented so that it's easier to read the diff and tell it was a refactor, and to separate the refactor changes from other changes. I didn't make the change to the error type or pulling the "Default" out into a constant, so Sandor, if you'd like to refactor your commits to make it clearer, or just build off my branch you can do so to get those other changes in. ---------------------------------------- Refactor #5079: MCX content provider https://projects.puppetlabs.com/issues/5079 Author: Sandor Szücs Status: Code Insufficient Priority: Normal Assignee: Sandor Szücs Category: OSX Target version: Affected Puppet version: Branch: I refactored the MCX content provider to enhance code readability. This is the first step to understand the current implementation. I would like to add a best practice dslocal solution pointed out by the authors of "Enterprise Mac Managed Preferences". They wrote that you should not use /Local/Default as DB, because it is also used as local cache. They further said that you should add an own DB to circumvent ping-pong overwrites between central managed MCX and dslocal managed MCX. The patch includes a small change within the spec file, because the error handling should be more conform to other puppet providers. Instead to raise MCXContentProviderException I choose to raise Puppet::Error, because macauthorization provider does the same. I hope that is the right Error handling. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
