Jira (PUP-8615) get_format relies on the order that .find processes the hash which causes it to fail on JRuby

[Eric Delaney (JIRA)]

Title: Message Title

Eric Delaney created an issue   Puppet / PUP-8615 get_format relies on the order that .find processes the hash which causes it to fail on JRuby Issue Type: Bug Assignee: Unassigned Created: 2018/03/28 11:57 AM Fix Versions: PUP 5.5.0 Priority: Normal Reporter: Eric Delaney get_format relies on the order that .find processes the hash which causes it to fail on JRuby This test fails under JRuby when the wrong formatter is selected: 1) The string converter when converting array multiple rules selects most specific Failure/Error: expect(converter.convert([1, 2], string_formats)).to eq('(1, 2)') expected: "(1, 2)" got: "[1, 2]" (compared using ==) # ./spec/unit/pops/types/string_converter_spec.rb:691:in `block in (root)' # util/rspec_runner:44:in `run' # util/rspec_runner:59:in `<main>' The underlying issue is in get_format(): https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/types/string_converter.rb#L1114 We call .find on the hash of the formatPoptions trying to find an assignable one to use: fmt = format_options.find {|k,_| k.assignable?(val_t) } So I added code to walk the list as .find would: fmt_false = format_options.find {|k,_| $stderr.puts("k: #{k.class} #{k.assignable?(val_t)}") $stderr.puts("k: #{k.inspect}") $stderr.puts("") false } On MRI Ruby this ends up with a list like this, where the 2nd entry is the formater that we expected to be used, we'd find and use that one: k: Puppet::Pops::Types::PHashType false k: #<Puppet::Pops::Types::PHashType:0x007fbdc5d2cbb8 @size_type=nil, @key_type=#<Puppet::Pops::Types::PAnyType:0x007fbdc5d2f570>, @value_type=#<Puppet::Pops::Types::PAnyType:0x007fbdc5d2f570>>   k: Puppet::Pops::Types::PArrayType true k: #<Puppet::Pops::Types::PArrayType:0x007fbdc50c5cf8 @size_type=#<Puppet::Pops::Types::PIntegerType:0x007fbdc50c5d20 @from=1, @to=2>, @element_type=#<Puppet::Pops::Types::PIntegerType:0x007fbdc5d2e1c0 @from=-Infinity, @to=Infinity>>   k: Puppet::Pops::Types::PArrayType true k: #<Puppet::Pops::Types::PArrayType:0x007fbdc5d2ce60 @size_type=nil, @element_type=#<Puppet::Pops::Types::PAnyType:0x007fbdc5d2f570>>   k: Puppet::Pops::Types::PBinaryType false k: #<Puppet::Pops::Types::PBinaryType:0x007fbdc3a27f50>   k: Puppet::Pops::Types::PFloatType false k: #<Puppet::Pops::Types::PFloatType:0x007fbdc5d2e080 @from=-Infinity, @to=Infinity>   k: Puppet::Pops::Types::PNumericType false k: #<Puppet::Pops::Types::PNumericType:0x007fbdc5d2e2d8 @from=-Infinity, @to=Infinity>   k: Puppet::Pops::Types::PObjectType false k: #<Puppet::Pops::Types::PObjectType:0x007fbdc5943650 @type_parameters={}, @attributes={}, @functions={}, @name=nil, @parent=nil, @equality_include_type=true, @equality=nil, @checks=nil, @annotations=nil>   k: Puppet::Pops::Types::PAnyType true k: #<Puppet::Pops::Types::PAnyType:0x007fbdc5d2f570> However on JRuby (jruby-9.1.15.0), running the same test the order that the .find will process the hash is different: k: Puppet::Pops::Types::PArrayType true k: #<Puppet::Pops::Types::PArrayType:0x687a0e40 @size_type=nil, @element_type=#<Puppet::Pops::Types::PAnyType:0x2db6d68d>>   k: Puppet::Pops::Types::PBinaryType false k: #<Puppet::Pops::Types::PBinaryType:0x33a47707>   k: Puppet::Pops::Types::PFloatType false k: #<Puppet::Pops::Types::PFloatType:0x720a1fd0 @to=Infinity, @from=-Infinity>   k: Puppet::Pops::Types::PHashType false k: #<Puppet::Pops::Types::PHashType:0x4abbe41c @key_type=#<Puppet::Pops::Types::PAnyType:0x2db6d68d>, @size_type=nil, @value_type=#<Puppet::Pops::Types::PAnyType:0x2db6d68d>>   k: Puppet::Pops::Types::PArrayType true k: #<Puppet::Pops::Types::PArrayType:0x2ef041bb @size_type=#<Puppet::Pops::Types::PIntegerType:0x45e7bb79 @to=2, @from=1>, @element_type=#<Puppet::Pops::Types::PIntegerType:0xedb83f8 @to=Infinity, @from=-Infinity>>   k: Puppet::Pops::Types::PNumericType false k: #<Puppet::Pops::Types::PNumericType:0xacb5508 @to=Infinity, @from=-Infinity>   k: Puppet::Pops::Types::PObjectType false k: #<Puppet::Pops::Types::PObjectType:0x3ac0a14b @functions={}, @checks=nil, @attributes={}, @equality_include_type=true, @name=nil, @annotations=nil, @parent=nil, @type_parameters={}, @equality=nil>   k: Puppet::Pops::Types::PAnyType true k: #<Puppet::Pops::Types::PAnyType:0x2db6d68d> Note that the first entry is an assignable? version, but its the 5th one that we're actually expected to be selected for the test to pass. We should do something so that the order we select these in is consistent between MRI and JRuby Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.