Jira (PUP-8728) A parameter that does not pass type validation can cause catalog compilation failure if used in the default expression of another parameter

[Nick Walker (JIRA)]

Title: Message Title

Nick Walker created an issue   Puppet / PUP-8728 A parameter that does not pass type validation can cause catalog compilation failure if used in the default _expression_ of another parameter Issue Type: Bug Assignee: Unassigned Created: 2018/05/14 3:32 PM Priority: Normal Reporter: Nick Walker The Problem Given the below code I would expect to get an error message back indicating that the test parameter didn't pass type validation but it instead causes failure in the function used in the parameter below. function puppet_enterprise::calculate_log_temp_files( Variant[String, Integer] $work_mem, ) >> Integer { #work_mem is specified in kB if no memory unit is provided if $work_mem =~ /\A(\d+)(kB|MB|GB|TB)\Z/ { $wm_size = $work_mem.pe_size() $work_mem_integer = $work_mem[0, $wm_size - 2] $work_mem_suffix = $work_mem[$wm_size-2, $wm_size] $multiplier = $work_mem_suffix ? { 'kb' => 1, 'MB' => 1024, 'GB' => 1024*1024, 'TB' => 1024*1024*1024, } $log_temp_files = Integer($work_mem_integer * $multiplier) } else { $log_temp_files = Integer($work_mem) } } class my_class ( Integer[64] $test, Integer $blah = puppet_enterprise::calculate_log_temp_files($test), ) { #do things } class { 'my_class' : test => 63, } Causes a failure like: [root@master201811-centos ~]# puppet apply /tmp/test.pp Error: Evaluation Error: Left match operand must result in a String value. Got an Integer. (file: /tmp/test.pp, line: 5, column: 6) on node master201811-centos.puppetdebug.vlan Expected Behavior If I fix the function so it doesn't fail then I get something like this which is the same thing I would expect since I don't expect the function to be evaluated if the first parameter doesn't pass type validation. Error: Evaluation Error: Error while evaluating a Resource Statement, Class[My_class]: parameter 'test' expects an Integer[64] value, got Integer[63, 63] Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.