Jira (PUP-8746) Improve time_metrics in report generation to use existing statuses

[Ethan Brown (JIRA)]

Title: Message Title

Ethan Brown created an issue   Puppet / PUP-8746 Improve time_metrics in report generation to use existing statuses Issue Type: Improvement Affects Versions: PUP 5.5.1, PUP 4.10.11 Assignee: Unassigned Created: 2018/05/16 1:24 PM Priority: Normal Reporter: Ethan Brown While looking for ways to influence report generation (to manipulate the types being reported by resources), a problematic line was discovered inside the metric calculation at https://github.com/puppetlabs/puppet/blob/5c092467789093d87228c1f471a469d314e3ae4f/lib/puppet/transaction/report.rb#L462:   type = Puppet::Resource.new(name).type   A new resource is being created solely to resolve its type name, which is already available inside the status object. That code originated in Feb 27, 2010 from lak at https://github.com/puppetlabs/puppet/commit/9919b14f262c994a58eb202cda408f1b90d728e0   At that point in time, resource_type was not part of the status object - https://github.com/puppetlabs/puppet/blob/9919b14f262c994a58eb202cda408f1b90d728e0/lib/puppet/resource/status.rb resource_type was later added in https://github.com/puppetlabs/puppet/commit/1f72c31f9e0223e71e2729da96e0e98ebea5417e for Puppet 1.5.2 in Dec 30, 2010, at which point the code above could have been refactored, but never was   The fix here should be a simple replacement of the call to generate a new resource with use of the already reported type. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.