Issue #5158 has been updated by Thomas Bellman.
If I were to design this from scratch and didn't have to worry about backwards
compatibility, I would throw out the current template() function entirely and
replace it with inline_template() (i.e, I would rename the current
inline_template() to just template()). People would then have to do
template(file("t1.erb"), file("t2.erb")) to get the functionality of the
current template("t1.erb", "t2.erb"). I also wouldn't have separate
directories for files and templates (I never understood that particular design
decision; I always symlink them together so I won't have to deal with that
annoyance).
This will also automatically give you the ability to use the first existing
template file, by doing template(file("foo-$host.erb", "foo-$domain.erb",
"foo.erb")). (This of course presumes that file() starts searching for files
the same way the current template() function does, and doesn't require absolute
paths.)
But this isn't backwards compatible at all, so it won't fly. :-(
----------------------------------------
Feature #5158: File resources: Make source/content parameters and the
file/template functions consistent.
https://projects.puppetlabs.com/issues/5158
Author: Nigel Kersten
Status: Accepted
Priority: High
Assignee:
Category:
Target version: Statler
Affected Puppet version:
Keywords: usability
Branch:
We have four main ways we can specify file content in a file resource.
1. The source parameter
2. The content parameter
3. The file function
4. The template function
These behave inconsistently in the following ways.
The source parameter, file function and template function all can take an
array. For source/file, the first file that exists will be used. For the
template function, we concatenate the templates instead.
The file function takes fully qualified paths only.
The template function takes fully qualified paths, or dereferences relative
paths as follows. 'foo/bar.erb' -> modules/foo/templates/bar.erb
The latter problem is relatively easily solved, particularly if we implement
#4885
We are going to have to break backwards compatibility to solve the first
problem however.
My feeling is that more people make use of the multi-select logic in the source
parameter/file function than make use of the concatenation of the template
function.
--
You have received this notification because you have either subscribed to it,
or are involved in it.
To change your notification preferences, please click here:
http://projects.puppetlabs.com/my/account
--
You received this message because you are subscribed to the Google Groups
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/puppet-bugs?hl=en.
