Issue #5299 has been updated by Nigel Kersten.

Status changed from Unreviewed to Accepted
Affected Puppet version deleted (2.6.3rc3)
Keywords set to usability


----------------------------------------
Bug #5299: Not helpful error message on failure with exported resources
https://projects.puppetlabs.com/issues/5299

Author: Peter Meier
Status: Accepted
Priority: Normal
Assignee: 
Category: 
Target version: 
Affected Puppet version: 
Keywords: usability
Branch: 


As mentioned in #5298 the error message for a failure with an exported resource 
is not very helpful as it includes a line number without a filename. The line 
number does not match the line on which the resources are collected, it seems 
more to match the line on which the resources are exported. Actually line 65 is 
one line below the end of the export definition.

As the problem occurs when we are collecting exporting resources I think the 
error message should include the line and file where the resources are 
collected.

Copying over the error message:

<pre>
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/util/errors.rb:60:in
 `fail'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/resource.rb:75:in
 `evaluate'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:255:in
 `evaluate_definitions'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:255:in
 `each'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:255:in
 `evaluate_definitions'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/util/errors.rb:35:in
 `exceptwrap'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:254:in
 `evaluate_definitions'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:270:in
 `evaluate_generators'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:265:in
 `loop'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:265:in
 `evaluate_generators'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:107:in
 `compile'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:18:in
 `compile'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector/catalog/compiler.rb:77:in
 `compile'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/util.rb:192:in
 `benchmark'
/opt/ruby-enterprise/lib/ruby/1.8/benchmark.rb:308:in `realtime'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/util.rb:191:in
 `benchmark'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector/catalog/compiler.rb:75:in
 `compile'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector/catalog/compiler.rb:34:in
 `find'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector/indirection.rb:193:in
 `find'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector.rb:50:in
 `find'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/handler.rb:101:in
 `do_find'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/handler.rb:68:in
 `send'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/handler.rb:68:in
 `process'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick/rest.rb:24:in
 `service'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/httpserver.rb:104:in `service'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/httpserver.rb:65:in `run'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:45
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:173:in `call'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:173:in `start_thread'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:162:in `start'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:162:in `start_thread'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:95:in `start'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:92:in `each'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:92:in `start'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:23:in `start'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:82:in `start'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:42:in
 `listen'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:41:in
 `initialize'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:41:in
 `new'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:41:in
 `listen'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:38:in
 `synchronize'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:38:in
 `listen'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/server.rb:127:in
 `listen'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/server.rb:142:in
 `start'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/daemon.rb:124:in
 `start'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application/master.rb:114:in
 `main'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application/master.rb:46:in
 `run_command'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application.rb:287:in
 `run'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application.rb:393:in
 `exit_on_fail'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application.rb:287:in
 `run'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/util/command_line.rb:55:in
 `execute'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/bin/puppet:4
/opt/ruby-enterprise/bin/puppet:19:in `load'
/opt/ruby-enterprise/bin/puppet:19
err: Cannot find definition Awstats::Server::Sitestorage at line 64 on node 
foo.bar.ch
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/parser/compiler.rb:21:in
 `compile'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector/catalog/compiler.rb:77:in
 `compile'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/util.rb:192:in
 `benchmark'
/opt/ruby-enterprise/lib/ruby/1.8/benchmark.rb:308:in `realtime'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/util.rb:191:in
 `benchmark'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector/catalog/compiler.rb:75:in
 `compile'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector/catalog/compiler.rb:34:in
 `find'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector/indirection.rb:193:in
 `find'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/indirector.rb:50:in
 `find'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/handler.rb:101:in
 `do_find'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/handler.rb:68:in
 `send'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/handler.rb:68:in
 `process'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick/rest.rb:24:in
 `service'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/httpserver.rb:104:in `service'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/httpserver.rb:65:in `run'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:45
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:173:in `call'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:173:in `start_thread'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:162:in `start'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:162:in `start_thread'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:95:in `start'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:92:in `each'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:92:in `start'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:23:in `start'
/opt/ruby-enterprise/lib/ruby/1.8/webrick/server.rb:82:in `start'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:42:in
 `listen'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:41:in
 `initialize'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:41:in
 `new'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:41:in
 `listen'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:38:in
 `synchronize'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/http/webrick.rb:38:in
 `listen'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/server.rb:127:in
 `listen'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/network/server.rb:142:in
 `start'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/daemon.rb:124:in
 `start'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application/master.rb:114:in
 `main'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application/master.rb:46:in
 `run_command'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application.rb:287:in
 `run'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application.rb:393:in
 `exit_on_fail'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/application.rb:287:in
 `run'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/lib/puppet/util/command_line.rb:55:in
 `execute'
/opt/ruby-enterprise/lib/ruby/gems/1.8/gems/puppet-2.6.3/bin/puppet:4
/opt/ruby-enterprise/bin/puppet:19:in `load'
/opt/ruby-enterprise/bin/puppet:19
err: Cannot find definition Awstats::Server::Sitestorage at line 64 on node 
foo.bar.ch
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to