Jira (PUP-7407) Add deprecation warning to Puppet::Util.absolute_path?

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on PUP-7407   Re: Add deprecation warning to Puppet::Util.absolute_path? After digging into this more, it looks like we have to preserve the existing implementation and do a docs only deprecation. The problem is that the absolute_path? method serves multiple purposes and it's hard to tell which from within the method. Sometimes it's used on the agent (in a type/provider) to validate that a parameter/property is an absolute path. This is common in puppet, and it would be better for custom types/provider to just use ruby to do this, e.g. Pathname.new(path).absolute?. Functions also use the method to validate paths. For example, stdlib has a deprecated function is_absolute_path, which calls the 3x version of the is_absolute_path function, which calls puppet's absolute_path? method. Since the compiler doesn't know whether it's compiling for a windows or unix node, the function verifies that it's an absolute path for either windows or unix, but it doesn't know exactly which. This can lead to false positives as /foo is absolute on unix, but not windows. With the introduction of puppet data types, it's better to do match values against the specific path data type: 'C:\foo' =~ Stdlib::Windowspath '/foo' =~ Stdlib::Unixpath See https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/unixpath.pp and https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/windowspath.pp. There is also https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/types/absolutepath.pp for the generic "is it unix or windows path" case. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.