Issue #5081 has been updated by James Turnbull.

Category set to executables
Status changed from Needs more information to Accepted
Assignee set to Nigel Kersten
Priority changed from Normal to High
Target version set to 2.6.x

So Dan is right ... and the problem is worse than just --ignoreimport.  
--parseonly itself appears broken since 2.6.0.
----------------------------------------
Bug #5081: Syntax checking not working with --ignoreimport
https://projects.puppetlabs.com/issues/5081

Author: Dan Carley
Status: Accepted
Priority: High
Assignee: Nigel Kersten
Category: executables
Target version: 2.6.x
Affected Puppet version: 2.6.1
Keywords: 
Branch: 


The use of `--ignoreimport` with `--parseonly` isn't raising errors on bad 
syntax. I've traced the last time this was working back to the tag of 
`2.6.0rc4`. This is important for those of us who use syntax checks in commit 
hooks, in order to prevent buggy manifests from going out.

It can be observed with the following:

<pre>
class test {
    file { "/tmp/foo":
        content => "bar",
        some invalid text
    }
}
</pre>

<pre>
d...@dan-macpro:~/projects/puppet$ git describe
2.6.0rc4
d...@dan-macpro:~/projects/puppet$ RUBYLIB=./lib ./bin/puppet --parseonly 
--ignoreimport ../test.pp; echo $?
err: Could not parse for environment production: Syntax error at 'invalid'; 
expected '}' at /home/dan/projects/test.pp:4
1
</pre>

<pre>
d...@dan-macpro:~/projects/puppet$ git describe
2.6.3rc1-105-gb1ef091
d...@dan-macpro:~/projects/puppet$ RUBYLIB=./lib ./bin/puppet --parseonly 
--ignoreimport ../test.pp
d...@dan-macpro:~/projects/puppet$ echo $?
0
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to