Jira (PUP-9043) file resource - mtime checksum does not seem to work

[Jeff Sparrow (JIRA)]

Title: Message Title

Jeff Sparrow commented on PUP-9043   Re: file resource - mtime checksum does not seem to work Josh Cooper - I think you hit it right on the head when you said this: However, i've noticed that if the connection is disconnected during download, ruby will ignore the resulting EOFError, which will cause puppet to write out a partial file. See https://github.com/ruby/ruby/blob/v2_4_4/lib/net/http/response.rb#L293 and https://github.com/ruby/ruby/blob/v2_4_4/lib/net/protocol.rb#L129. And since puppet completes the file download, it will rename the temporary truncated file over the real file, and will not update the file again (until the mtime changes on the server). We dug into this a bit further yesterday.  That is exactly what has happened on our side, it appears.  The Puppet run was done during the transfer of that file to artifactory.  It is transferred around 6am every day, then this specific group runs puppet around 8-9am.  However, on this day, the file wasnt transferred to Artifactory until around 8am.  At 1.4GB it took a couple seconds, and it appears only part of the file was downloaded during this teams Puppet runs.   Then, as you alluded to, Puppet will never update the file again, because the mtime locally is greater than or equal to the remote file.  Since the mtime is actually greater, but the file was incomplete, it would never be resolved again; except through manual intervention.   Thus, between no md5 availability for artifactory, or mtime not being rechecked, the file will always be bad.   Just curious, is there a reason that the greater than **portion of mtime checking exists?  I understand there would be a slight time difference for transfer, but it would seem that if its an extended period of time, say beyond an hour or so difference, that the file has likely been changed (or in our case is incorrect all together) and thus puppet would then view the file as not being the same? Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.