Jira (FACT-1873) Custom facts that aren't suitable should not override built-in facts

[Sean Millichamp (JIRA)]

Title: Message Title

Sean Millichamp created an issue   Facter / FACT-1873 Custom facts that aren't suitable should not override built-in facts Issue Type: Improvement Affects Versions: FACT 3.11.3 Assignee: Unassigned Created: 2018/08/10 1:59 PM Priority: Normal Reporter: Sean Millichamp As a user of Facter, I would expect that a custom fact, with weight > 0, and with confines which have it result in being not suitable for the current system should not replace the built-in fact with an empty result. Or, put more generally, I would expect facter to pick the highest weighted fact available from the set of facts where the confines return success. Example with a fact in myfacts/custom.rb: Facter.add(:timezone) do   has_weight 10   confine { File.exist?('/tmp/fact_trigger') }   setcode do     'my_custom_timezone'   end end and: $ facter timezone UTC then, as expected: $ touch /tmp/fact_trigger $ facter --custom-dir=myfacts timezone my_custom_timezone after removing /tmp/fact_trigger, causing the confine to fail: $ rm /tmp/fact_trigger $ facter --custom-dir=myfacts timezone   ${noformat} what I would have expected to happen is: $ rm /tmp/fact_trigger $ facter --custom-dir=myfacts timezone UTC ${noformat}   The behavior as it is today prevents targeted fixing of particular facts on specific platforms that don't work as well as on other platforms by narrowing down the scope with confines. Thank you.   Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.