Issue #5510 has been updated by Daniel Pittman.

Hey.  Can you identify an actual problem caused by this, other than the order 
of facts changing when they are loaded?

My expectation would be that this should not matter - ordering dependencies 
between facts should be explicit, if they exist, rather than depending on an 
implementation detail like load order.

I would also expect that committing to loading facts in a specific order runs 
the risk that we are tied to providing that API forever, which means that any 
changes to the implementation later (like lazy evaluation, say) might suddenly 
run into the additional complexity of having to emulate this commitment to 
implementations...

Having a real world problem caused by that failure would make it much easier to 
work out if this is a commitment we should make. :)
----------------------------------------
Bug #5510: facter custom fact ruby files should be loaded deterministically
https://projects.puppetlabs.com/issues/5510

Author: Rick Bradley
Status: Unreviewed
Priority: Normal
Assignee: 
Category: 
Target version: 
Keywords: 
Branch: 


When defining a set of custom facts via ruby libraries, the libraries are not 
loaded deterministically on different operating systems and/or filesystems.  
When a ruby-defined fact definition relies on the definition of other 
ruby-defined facts, the facts may not be evaluated depending upon the operating 
system / filesystem in use (e.g., Mac OSX by default appears to sort, while 
some variants of linux on ext3 appears to use another ordering).

The problem is that the return result from ruby's Dir.entries varies from 
platform to platform.

The obvious fix is to sort the return value from Dir.entries before use.

A pull request with specs for the problem and a resolution is forthcoming.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to