Jira (PUP-9157) Puppet 6 failing tests on Windows with mocked os facts

[Bryan Jen (JIRA)]

Title: Message Title

Bryan Jen created an issue   Puppet / PUP-9157 Puppet 6 failing tests on Windows with mocked os facts Issue Type: Task Affects Versions: PUP 6.0.0 Assignee: Unassigned Created: 2018/09/19 6:48 PM Priority: Critical Reporter: Bryan Jen On a module with mocked os facts using rspec-puppet-facts like: describe 'module' do on_supported_os.each do |os, os_facts| context "on #{os}" do let(:facts) { os_facts } it { is_expected.to compile } end end end These tests that passed on Windows on Puppet 5.5.6 and Facter 2.5.1 are now failing on Puppet 6.0.0 and Facter 2.5.1. Here is a gist to the relevant stack trace: https://gist.github.com/bmjen/7b1ce2380e27178492c12999c8039daf Upon further debug, I believe I was able to isolate the problem to the usage of `Puppet::Util.windows?` instead of `Facter.value(:kernel) == "windows"`. Such as here: https://github.com/puppetlabs/puppet/blob/6a96dc22839b363cf9d3d2125896ac71cb68b5f5/lib/puppet/defaults.rb#L36 Which will return as `True` on Windows regardless of what Facter shows as the kernel and OS. I can provide more information and a repro environment if necessary. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.