Jira (BOLT-914) Loading bolt/executor is "breaking" gettext setup in spec tests

[Glenn Sarti (JIRA)]

Title: Message Title

Glenn Sarti created an issue   Puppet Task Runner / BOLT-914 Loading bolt/executor is "breaking" gettext setup in spec tests Issue Type: Task Affects Versions: BOLT 0.25.0 Assignee: Unassigned Created: 2018/10/08 12:29 AM Environment: Windows 10 - 1803 Puppet Gem 6.0.2 Ruby 2.4.2 (yes I know, but it fails in 2.5 as well) Bolt 0.25.0 Priority: Normal Reporter: Glenn Sarti I was investigating issues with a pull request on the Puppetlabs Reboot module which was attempting to add tests for a new bolt-only function. Pull Request - https://github.com/puppetlabs/puppetlabs-reboot/pull/171 As part of this, tests outside of the change started to fail Puppet::Type::Reboot parameter :when defaults to :refreshed accepts :pending rejects other values (FAILED - 1)   Failures:   1) Puppet::Type::Reboot parameter :when rejects other values Failure/Error: resource[:when] = :whenever   FastGettext::Storage::NoTextDomainConfigured: Current textdomain ("master_domain") was not added, use FastGettext.add_text_domain ! # ./.bundle/windows/ruby/2.4.0/gems/fast_gettext-1.1.2/lib/fast_gettext/storage.rb:79:in `current_repository' # ./.bundle/windows/ruby/2.4.0/gems/fast_gettext-1.1.2/lib/fast_gettext/storage.rb:87:in `block in cached_find' # ./.bundle/windows/ruby/2.4.0/gems/fast_gettext-1.1.2/lib/fast_gettext/cache.rb:11:in `fetch' # ./.bundle/windows/ruby/2.4.0/gems/fast_gettext-1.1.2/lib/fast_gettext/storage.rb:87:in `cached_find' # ./.bundle/windows/ruby/2.4.0/gems/fast_gettext-1.1.2/lib/fast_gettext/translation.rb:22:in `_' # ./.bundle/windows/ruby/2.4.0/gems/puppet-6.0.2-x64-mingw32/lib/puppet/parameter.rb:467:in `rescue in validate' # ./.bundle/windows/ruby/2.4.0/gems/puppet-6.0.2-x64-mingw32/lib/puppet/parameter.rb:459:in `validate' # ./.bundle/windows/ruby/2.4.0/gems/puppet-6.0.2-x64-mingw32/lib/puppet/property.rb:548:in `block in should=' # ./.bundle/windows/ruby/2.4.0/gems/puppet-6.0.2-x64-mingw32/lib/puppet/property.rb:548:in `each' # ./.bundle/windows/ruby/2.4.0/gems/puppet-6.0.2-x64-mingw32/lib/puppet/property.rb:548:in `should=' # ./.bundle/windows/ruby/2.4.0/gems/puppet-6.0.2-x64-mingw32/lib/puppet/property.rb:606:in `value=' # ./.bundle/windows/ruby/2.4.0/gems/puppet-6.0.2-x64-mingw32/lib/puppet/type.rb:674:in `[]=' # ./spec/unit/type/reboot_spec.rb:49:in `block (3 levels) in <top (required)>' # ------------------ # --- Caused by: --- # FastGettext::Storage::NoTextDomainConfigured: # Current textdomain ("master_domain") was not added, use FastGettext.add_text_domain ! # ./.bundle/windows/ruby/2.4.0/gems/fast_gettext-1.1.2/lib/fast_gettext/storage.rb:79:in `current_repository' This seemed to be a problem with semantic_puppet as it was introduced back into the Puppet gem in version 6.0+ However after a lot of spelunking I figured out that fast gettext was being initialized mutliple times. This is the list of requires; bolt/executor requires bolt/config which requires bolt/cli which requires r10k/action/puppetfile/install which requires r10k/puppetfile which requires r10k/module - which requires r10k and r10k/module/base r10k/module/base requires r10k/module which requires puppetforge r10k initializes GetText at; https://github.com/puppetlabs/r10k/blob/master/lib/r10k.rb#L4 puppetforge initializes GetText at https://github.com/puppetlabs/forge-ruby/blob/master/lib/puppet_forge.rb#L18 If I comment out the initialize commands then the rspec tests work fine. Does the bolt team have any recommendations on how to unit test with bolt in modules? Are there any workarounds for this behaviour? (besides some hacky monkey patching) Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.