Jira (PUP-9247) Puppet pidlock checks only look for PID if it is running, not process name

[Mike Smith (JIRA)]

Title: Message Title

Mike Smith created an issue   Puppet / PUP-9247 Puppet pidlock checks only look for PID if it is running, not process name Issue Type: Bug Affects Versions: PUP 6.0.2 Assignee: Unassigned Created: 2018/10/18 1:07 PM Priority: Normal Reporter: Mike Smith Puppet Version: 6.0.2 (or any) Puppet Server Version:  2018.1 OS Name/Version: Windows (linux most likely as well) When puppet runs it created the pidlock file with the pid of puppet.  If puppet stops/crashes while running the lock file remains.  Puppet reads the file, checks for pid as integer, and sees if that pid is running (system.kill(0) to see if alive). If ANY PID responds, it locks, even if the PID is not a puppet PID. Desired Behavior: Puppet should check PID to see if it is running and its puppet, not just running. Actual Behavior: if any process has that pid, puppet locks. Steps to replicate (tested on windows 2016 with Puppet 6.0.2) 1 - start puppet run with 'puppet agent -t' 2 - while running stop the puppet/puppet-pxp agent services 3 - open pidloclk file, there should be a PID there 4 - change PID lock file contents to any other currently running PID 5 - start puppet / run 'puppet agent -t' Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.